200378 - Command+clicking in the Bookmarks Toolbar does not open a new window

Status: VERIFIED FIXED

(Camino Graveyard :: Accessibility, defect)

Description

[Jon Stevens]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4a) Gecko/20030401 Chimera/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4a) Gecko/20030401 Chimera/0.7+

I hold down the command key and click on a bookmark in the Bookmakrs Toolbar and
it does not open a new window. It would be nice if this was the behavior since
it would be consistent with what happens when I command click on a link in the
browser window.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Greg K.]

Confirmed using Camino/20030402??. Curiously, command+clicking Bookmarks Toolbar
items *does* spawn new tabs if that's set in Preferences/Navigation/Tabbed
Browsing/"Clicking a link with the Command key down:" is set to "Opens a new
tab", but *doesn't* spawn a new window if it's set to "Opens a new window".

Comment 2

[Ludovic Hirlimann [:Usul]]

still true with 2003082402.

Comment 3

[Simon Fraser [no longer active]]

Taking. This needs to work for both bookmark toolbars, and items in bookmark toolbar submenus (and 
maybe even the bookmarks menu itself).

Comment 4

[Simon Fraser [no longer active]]

Attachment: Factor the bookmarks opening code, and fix this bug

This patch moves all of the code that opens bookmarks (from bookmark buttons,
bookmark menus etc) into one central method, which checks the prefs, and key
modifiers, and opens in new window/tab in foreground/background accordingly. So
now we have these behaviours:

* Command-clicking a toolbar tab group adds the new tabs (or puts them in a new
window), rather than replacing tabs
* If the prefs are set to open new windows, command-clicking bookmarks and tab
groups will open
   them in new windows (optionally behind the current window)
* Holding down the command-click while choosing bookmarks or tab groups from
the menus (incl. dock menu and toolbar folder menu) will follow the new tab/new
window behavior

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 141980 [details] [diff] [review]
Factor the bookmarks opening code, and fix this bug

looks good, builds with no additional warnings so you got all the call sites.

the only issue is that if you cmd-dblclick a bookmark in the manager, if it
wasn't already seleted, you just end up toggling it. you have to have the item
previously selected before the dbl-click actually works. however, that's
probably beyond the scope of this patch and an issue with our outliner.

r=pink

Comment 6

[Mike Pinkerton (not reading bugmail)]

getting on 0.8 radar.

Comment 7

[Simon Fraser [no longer active]]

Checked in.

Comment 8

[Jon Stevens]

verified fixed.