2007147 - The search bar's suggestion pop-up appears behind the URL bar when the search bar customized to place on menubar

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Alice0775 White]

Attachment: screenshot

Steps to reproduce:

1. Enable Menu bar
2. Customize the search bar to be placed in the menu bar
3. Restart browser
4. Type search text into the search bar. e.g.,Firefox

Actual results:
The search bar's suggestion pop-up appears behind the URL bar

Expected results:
The search bar's suggestion pop-up should appear at the top most window

Comment 1

[BugBot [:suhaib / :marco]]

:dao, since you are the author of the regressor, bug 2006632, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alice0775 White]

Attachment: Screenshot: When search bar customized to place on bookmarks toolbar

Alternatively, if you customize the search bar to be placed on the bookmarks toolbar, the URL bar suggestion pop-up will appear behind the search bar.

Steps to reproduce 2:

1. Enter Customize toolbar mode
2. Set Bookmarks toolbar Always show
3. Customize the search bar to be placed on the bookmark toolbar
4. Restart browser
5. Type something into urlbar

Comment 3

[Alice0775 White]

This issue is reproduced on uBuntu22.04.

Comment 4

[Alice0775 White]

The issue of STR comment#1 was fixed by Bug 2007341.
However, the issue of STR comment#2 is still reproduced.

Comment 5

[Alice0775 White]

About the issue of STR comment#2, execute setTimeout(() => { gURLBar._on_uidensitychanged(); }, 1500); in Console fix the issue.

Comment 6

[Moritz Beier [:mbeier]]

The reason this happens is that both the urlbar and searchbar are now popovers and the order in which they are displayed is the order in which they called showPopover.
An easy fix would be to do showPopover when opening the results panel and hidePopover when closing it so only one of the two is a popover at a time, but calling showPopover while selecting text messes with the selection (nothing gets selected).
Emilio, do you have an idea how to solve this issue?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Obvious approach would be to make them popovers only on focus (very similar, but not quite the same to what you suggested), is that possible?

but calling showPopover while selecting text messes with the selection (nothing gets selected).

Can you elaborate, do you have a screencast or something? You mean just text selection or the url highlighting which uses custom stuff (the one to un-highlight subdomains and such).

Comment 8

[Emilio Cobos Álvarez [:emilio]]

If it's regular text selection, it should reproduce on a regular website, and it should be fixable in any case.

Comment 9

[Moritz Beier [:mbeier]]

Attachment: Calling showPopover while selecting text

Comment 10

[Moritz Beier [:mbeier]]

Yes, regular text selection. I can also reproduce it on regular websites when calling showPopover on mousedown and hidePopover on mouseup (and display: block)

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Can you file it separately please? Core :: Selection for the component :)

It probably reproduces when switching display type as well (e.g. if instead of showPopover() you change display to e.g. flex).

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Maybe doing it on focus works, tho?

Comment 13

[Moritz Beier [:mbeier]]

Yeah it also happens when switching display type. I filed bug 2014481 and attached an example there.

Comment 14

[Moritz Beier [:mbeier]]

Attachment: Bug 2007147 - The search bar's suggestion pop-up appears behind the URL bar when the search bar is placed on the menubar. r?dao

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/33e695145110
https://hg.mozilla.org/integration/autoland/rev/90e8ccebc029
The search bar's suggestion pop-up appears behind the URL bar when the search bar is placed on the menubar. r=dao,urlbar-reviewers

Comment 16

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/90e8ccebc029

Comment 17

[Petruta Horea [:phorea]]

Verified as fixed using Firefox 149 beta 6 and latest Nightly 150.0a1 under Win 11, Ubuntu 24 and macOS 15.