20090 - nsWebShell::Embed sometimes returns garbage

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

In the beginning of the Embed method we have

nsresult rv;

but if mWindow == nsnull the function returns the unitialized rv.

A related note. If mWindow == nsnull, the function nulls out mContentViewer. But
if it was not null, this results in bad refcounts & memory leaks.

Also, why does it need to null out mContentViewer? For example, (well, this may
be misuse but this is what I have done right now and it would require a lot of
changes to do it otherwise), I have a command-line application (no windows) that
loads documents with the webshell. Strange as this may sound, it works except
for this Embed part, because if this Embed nulls out mContentViewer I can never
get the document object out once it has been loaded.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Oops, wrong Assigned To. I'll make a patch as well...

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: FIX: Return NS_OK if no mWindow, do not null mContentViewer

Comment 3

[travis]

This function will be going away completely very soon now with the webShell
redesign.

Comment 4

[don]

Move to M15 for later evaluation.

Comment 5

[travis]

The Embed method is gone for nearly all purposes.  It's implementation is 
provided by another internal interface.  Marking this fixed since all the code 
is new.

Comment 6

[leger]

Adding verifyme keyword.

Comment 7

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Verified.