Closed
Bug 201012
Opened 22 years ago
Closed 22 years ago
get rid of offline warnings in debug builds
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: axel, Assigned: axel)
Details
Attachments
(1 file)
|
688 bytes,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
I mostly do debugging work offline, so the offline warning fills my console
window. Which I intend to use for debugging ;-).
I'll attach a patch to not use NS_ENSURE_TRUE, but just an if() in
nsSocketTransportService::PostEvent
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 119667 [details] [diff] [review]
drop NS_ENSURE_TRUE in favor of plain if()
requesting sr, any suggestions for r=?
Attachment #119667 -
Flags: superreview?(darin)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 119667 [details] [diff] [review]
drop NS_ENSURE_TRUE in favor of plain if()
r+sr=me .. no need for further reviews. just please bag the extraneous { }
since those are inconsistent with the style of this file.
Attachment #119667 -
Flags: superreview?(darin)
Attachment #119667 -
Flags: superreview+
Attachment #119667 -
Flags: review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•