As Pierre already pointed out, this is the real fix for all the bugs related to uninitialized transaction manager in 2nd window. I'll add dependencies later. Patch coming ...
I think it's not exactly the 2nd window, but every window opened after e.g. doing d'n'd in the PT (or other bookmarks things). But you probably just wanted to make the description shorter, so as long as the patch helps, go for it! :-)
Exactly, I'm sure Pierre knows what I'm talking about ;)
Comment on attachment 119670 [details] [diff] [review] patch Thanks for the patch, Jan. Maybe the bookmark transaction manager should be lazily initialized in GetBookmarkManager? It's up to you
Comment on attachment 119670 [details] [diff] [review] patch I don't think you need an NS_IF_ADDREF there, just NS_ADDREF should do. If nsBookmarksService::Init failed (which it will if mTransactionManager is nsnull) you shouldn't have access to the service, so you wouldn't be able to addref a null there. sr=jag
Quick question: (when) is the transaction manager released?
thanks for reviews, btw
Verified per last comments.