Move bookmarks transaction manager to bookmarks service

VERIFIED FIXED in mozilla1.4beta

Status

SeaMonkey
Bookmarks & History
P3
normal
VERIFIED FIXED
15 years ago
13 years ago

People

(Reporter: janv, Assigned: janv)

Tracking

Trunk
mozilla1.4beta
x86
All
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

9.85 KB, patch
Pierre Chanial
: review+
jag (Peter Annema)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
As Pierre already pointed out, this is the real fix for all the bugs related to
uninitialized transaction manager in 2nd window.
I'll add dependencies later.
Patch coming ...
(Assignee)

Updated

15 years ago
Blocks: 199364
(Assignee)

Comment 1

15 years ago
Created attachment 119670 [details] [diff] [review]
patch
(Assignee)

Updated

15 years ago
Attachment #119670 - Flags: superreview?(jaggernaut)
Attachment #119670 - Flags: review?(chanial)
(Assignee)

Updated

15 years ago
Blocks: 200771
Status: NEW → ASSIGNED

Comment 2

15 years ago
I think it's not exactly the 2nd window, but every window opened after e.g.
doing d'n'd in the PT (or other bookmarks things). 
But you probably just wanted to make the description shorter, so as long as the
patch helps, go for it! :-)
(Assignee)

Comment 3

15 years ago
Exactly, I'm sure Pierre knows what I'm talking about ;)
(Assignee)

Updated

15 years ago
Priority: -- → P3
Target Milestone: --- → mozilla1.4beta

Comment 4

15 years ago
Comment on attachment 119670 [details] [diff] [review]
patch

Thanks for the patch, Jan.
Maybe the bookmark transaction manager should be lazily initialized in
GetBookmarkManager?
It's up to you
Attachment #119670 - Flags: review?(chanial) → review+

Comment 5

15 years ago
Comment on attachment 119670 [details] [diff] [review]
patch

I don't think you need an NS_IF_ADDREF there, just NS_ADDREF should do. If
nsBookmarksService::Init failed (which it will if mTransactionManager is
nsnull) you shouldn't have access to the service, so you wouldn't be able to
addref a null there.

sr=jag
Attachment #119670 - Flags: superreview?(jaggernaut) → superreview+

Comment 6

15 years ago
Quick question: (when) is the transaction manager released?
(Assignee)

Comment 7

15 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

15 years ago
thanks for reviews, btw

Comment 9

15 years ago
Verified per last comments.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.