2010135 - [fluent-dom] While translating an element with fluent ID "newtab-topsites-add-shortcut-label" a child element of type "br" was removed.

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Rob Wu [:robwu]]

I reported this before as bug 1977057, but despite the fix there, I still see the following warning repeated multiple times when I run ./mach run --temp-profile from a debug build (which opens the new tab page):

[fluent-dom] While translating an element with fluent ID "newtab-topsites-add-shortcut-label" a child element of type "br" was removed. Either the fluent message does not contain markup, or it does not contain markup of this type.

The culprit is still the same as in bug 1977057, at https://searchfox.org/firefox-main/rev/e1eada69e2ddd86a398ccb141dcbf772254162eb/browser/extensions/newtab/content-src/components/TopSites/TopSite.jsx#430,435

I guess that title is blank, and falls back to <br />, which is ignored since it is missing from the translation.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1973214

:thecount, since you are the author of the regressor, bug 1973214, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 2010135 - Remove <br> fallback from TopSite title-label span r?#home-newtab-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5d161d2a6cad
https://hg.mozilla.org/integration/autoland/rev/fc4b1a94b08b
Remove <br> fallback from TopSite title-label span r=home-newtab-reviewers,robwu,ini

Comment 4

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/fc4b1a94b08b