20105 - Uninitialized memory read in nsLineLayout::CanPlaceFrame

Status: VERIFIED DUPLICATE of bug 18622

(Core :: Layout, defect, P3)

Description

[David Gardiner]

Running Purify for NT on Viewer.exe, i get an UMR. I would
expect the problem would also be evident in mozilla.exe

[W] UMR: Uninitialized memory read in
nsLineLayout::CanPlaceFrame(PerFrameData::nsLineLayout *,nsHTMLReflowState
const&,int,nsHTMLReflowMetrics&,UINT&) {1 occurrence}
    Reading 4 bytes from 0x05edd4bc (4 bytes at 0x05edd4bc uninitialized)
    Address 0x05edd4bc is 132 bytes into a 140 byte block at 0x05edd438
    Address 0x05edd4bc points to a C++ new block in heap 0x03830000
    Thread ID: 0x628
    Error location
        nsLineLayout::CanPlaceFrame(PerFrameData::nsLineLayout
*,nsHTMLReflowState const&,int,nsHTMLReflowMetrics&,UINT&)
[nsLineLayout.cpp:1341]

                  // If this is a piece of text inside a letter frame...
                  if (pfd->mIsNonEmptyTextFrame) {
             =>     if (psd->mFrame && psd->mFrame->mIsLetterFrame) {
                      nsIFrame* prevInFlow;
                      psd->mFrame->mFrame->GetPrevInFlow(&prevInFlow);
                      if (prevInFlow) {
        nsLineLayout::ReflowFrame(nsIFrame *,nsIFrame *
*,UINT&,nsHTMLReflowMetrics *) [nsLineLayout.cpp:1118]
        nsInlineFrame::ReflowInlineFrame(nsIPresContext *,nsHTMLReflowState
const&,InlineReflowState::nsInlineFrame&,nsIFrame *,UINT&)
[nsInlineFrame.cpp:489]
        nsInlineFrame::ReflowFrames(nsIPresContext *,nsHTMLReflowState
const&,InlineReflowState::nsInlineFrame&,nsHTMLReflowMetrics&,UINT&)
[nsInlineFrame.cpp:347]
        nsInlineFrame::Reflow(nsIPresContext
*,nsHTMLReflowMetrics&,nsHTMLReflowState const&,UINT&) [nsInlineFrame.cpp:274]
        nsLineLayout::ReflowFrame(nsIFrame *,nsIFrame *
*,UINT&,nsHTMLReflowMetrics *) [nsLineLayout.cpp:955]
        nsInlineFrame::ReflowInlineFrame(nsIPresContext *,nsHTMLReflowState
const&,InlineReflowState::nsInlineFrame&,nsIFrame *,UINT&)
[nsInlineFrame.cpp:489]
        nsInlineFrame::ReflowFrames(nsIPresContext *,nsHTMLReflowState
const&,InlineReflowState::nsInlineFrame&,nsHTMLReflowMetrics&,UINT&)
[nsInlineFrame.cpp:347]
        nsInlineFrame::Reflow(nsIPresContext
*,nsHTMLReflowMetrics&,nsHTMLReflowState const&,UINT&) [nsInlineFrame.cpp:274]
        nsLineLayout::ReflowFrame(nsIFrame *,nsIFrame *
*,UINT&,nsHTMLReflowMetrics *) [nsLineLayout.cpp:955]

Comment 1

[David Gardiner]

Attachment: Fix UMR

Comment 2

[kinmoz]

I checked in a fix for this today. Marking as a dup of 18622.

*** This bug has been marked as a duplicate of 18622 ***

Comment 3

[Chris Petersen]

Marking verified dup of 18622.