Closed
Bug 201102
Opened 23 years ago
Closed 23 years ago
No selected area in View Selection Source
Categories
(Core Graveyard :: View Source, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rbs, Assigned: rbs)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
1.58 KB,
patch
|
doronr
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Recent regression: View Selection Source is not highlighting the selected markup
anymore.
Taking the bug. The JS is dumping an exception and I see where the problem is
coming from.
Somehow, the initial caret/focus point isn't at the top of the document anymore.
And so the internal find that is done to find the selection marker is failing.
Assignee: doron → rbs
Attachment #120014 -
Attachment is obsolete: true
Comment on attachment 120029 [details] [diff] [review]
same as above with a nice-to-have extra for selectAll while here
ready for r/sr
Attachment #120029 -
Flags: superreview?(bzbarsky)
Attachment #120029 -
Flags: review?(doron)
|
||
Updated•23 years ago
|
Attachment #120029 -
Flags: superreview?(bzbarsky) → superreview+
|
||
Updated•23 years ago
|
Attachment #120029 -
Flags: review?(doron) → review+
Checked in. Also adjusted some of those delicate range indices (but they
essentially used for beautifications of the selected area in this case, e.g., to
make it appear as if it is aligned with tag boundaries, [<tag>...</tag>]).
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•