Various commands need to accept UTF8 strings in addition to/instead of ASCII strings. In particular, cmd_fontFace. The others (align, color, bgcolor, etc.) appear to get by with a char string.
QA Contact: sairuh → carosendahl
Whiteboard: edt_x3 topembed editorbase
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Hardware: PC → All
Whiteboard: edt_x3 topembed editorbase → edt_x3 editorbase
topembed triage: plussing, required by international product localizations of Gecko embedding customers.
Keywords: topembed → topembed+
Created attachment 120677 [details] [diff] [review] proposed fix - use nsString instead of nsCString
add myself to cc
Comment on attachment 120677 [details] [diff] [review] proposed fix - use nsString instead of nsCString Taka--r=brade for branch (assuming you have tested it with satisfactory results) I think the trunk will require a different (but nearly identical patch) and testing with jag's work.
Attachment #120677 - Flags: review+
Checking in nsComposerCommands.cpp; /cvsroot/mozilla/editor/composer/src/nsComposerCommands.cpp,v <-- nsComposerCo mmands.cpp new revision: 188.8.131.52; previous revision: 184.108.40.206 done checked into branch.
Created attachment 120764 [details] [diff] [review] taka's patch ported to trunk
Attachment #120677 - Attachment is obsolete: true
Comment on attachment 120764 [details] [diff] [review] taka's patch ported to trunk carryforward my r= jag--can you please test with your changes and sr=? I can't test font menu in my debug build on macho (I get JS warnings/errors on console).
Whiteboard: edt_x3 editorbase → edt_x3 editorbase+
Comment on attachment 120764 [details] [diff] [review] taka's patch ported to trunk sr=jag
Attachment #120764 - Flags: superreview?(jaggernaut) → superreview+
I believe this is already addressed where appropriate. If there are specific cases, we should file them as separate bugs.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.4beta
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.