2013477 - Support action.isEnabled(tabId) next to action.isEnabled(details)

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Rob Wu [:robwu]]

Following agreement in the WECG to support the action.isEnabled(integer tabId) type (that Chrome is currently the only implementer of) in addition to the action.isEnabled(object details) syntax (that Firefox and Safari already support), let's implement it.

This makes action.isEnabled(tabId) also more fitting with the signatures of action.enable(tabId) and action.disable(tabId).

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 2013477 - Support action.isEnabled(tabId)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/535452fdb977
https://hg.mozilla.org/integration/autoland/rev/1b1c0d63142c
Support action.isEnabled(tabId) r=rpl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ec9b2c3d5961
https://hg.mozilla.org/integration/autoland/rev/6d6a90d923ce
Revert "Bug 2013477 - Support action.isEnabled(tabId) r=rpl" for causing mochitest failures on test_ext_action.html

Comment 4

[rperta]

Backed out for causing mochitest failures on test_ext_action.html
Backout link
Push with failures
Failure log(s)

Comment 5

[Rob Wu [:robwu]]

Debug-only rejected name property in the schema; going to reland without it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a4137ec7c217
https://hg.mozilla.org/integration/autoland/rev/6756aa669bb0
Support action.isEnabled(tabId) r=rpl

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6756aa669bb0

Comment 8

[rbloor]

BCD changes included in Bug-2012727 action.isEnabled updated properties info #28964. MDN changes to follow next week.

Comment 9

[rbloor]

MDN documeation changes included in Bug-2012727 isEnabled updates for action and browseAction #42997