2013822 - Wait for navigation-committed event for navigation to error page

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Julian Descottes [:jdescottes]]

See Bug 1984535. In case of a navigation which redirects to an error page, the document might not be ready when resolving because we currently resolve immediately on location change.

Instead we should wait for navigation-committed. Although we need to be careful to wait for the correct navigation committed event, because we might already have received one for the original URL (before the error redirect).

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 2013822 - [remote] Wait for navigation committed when navigating to error page

When a navigation redirects to an error page we should still wait for the navigation committed
event to make sure the document is ready to be used.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/97f176630fad
https://hg.mozilla.org/integration/autoland/rev/1dea65bcffd5
[remote] Wait for navigation committed when navigating to error page r=whimboo

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/1dea65bcffd5

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Frequent intermittents tracked in Bug 1984535
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: low
• Explanation of risk level: WebDriver BiDi only, and only updating the logic related to navigations which lead to an error page.
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 2013822 - [remote] Wait for navigation committed when navigating to error page

When a navigation redirects to an error page we should still wait for the navigation committed
event to make sure the document is ready to be used.

Original Revision: https://phabricator.services.mozilla.com/D281390

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2033177c7c39
https://hg.mozilla.org/releases/mozilla-beta/rev/27cb6f748e03