201400 - add getter and observer for browse with caret to event state manager

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Kathleen :Brade]

Event State Manager (which has mBrowseWithCaret) needs a getter so it can be
queried for and not just toggled.

Comment 1

[Kathleen :Brade]

Attachment: patch based on conversation with aaronl

Comment 2

[Kathleen :Brade]

Comment on attachment 120005 [details] [diff] [review]
patch based on conversation with aaronl

Aaron--I haven't tested this yet (I need a clean tree to test it on); could you
do a conditional review (conditional that it not break anything)?

Comment 3

[Aaron Leventhal]

Comment on attachment 120005 [details] [diff] [review]
patch based on conversation with aaronl

r=aaronl as long as it doesn't break anything :)

Also, once you eliminate ResetBrowseWithCaret() from nsDOMWindowController, it
can be removed from nsIEventStateManager and be turned into a helper:
void ResetBrowseWithCaret(void)

Comment 4

[Simon Fraser [no longer active]]

Attachment: Tweaked version of the patch, doesn't crash.

Comment 5

[Simon Fraser [no longer active]]

Comment on attachment 120270 [details] [diff] [review]
Tweaked version of the patch, doesn't crash.

Moving r= forward, sr=me

Comment 6

[Simon Fraser [no longer active]]

Checked in.