If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

add getter and observer for browse with caret to event state manager

RESOLVED FIXED

Status

()

Core
Event Handling
RESOLVED FIXED
15 years ago
4 years ago

People

(Reporter: Kathleen Brade, Assigned: Kathleen Brade)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

15 years ago
Event State Manager (which has mBrowseWithCaret) needs a getter so it can be
queried for and not just toggled.
(Assignee)

Comment 1

15 years ago
Created attachment 120005 [details] [diff] [review]
patch based on conversation with aaronl
(Assignee)

Comment 2

15 years ago
Comment on attachment 120005 [details] [diff] [review]
patch based on conversation with aaronl

Aaron--I haven't tested this yet (I need a clean tree to test it on); could you
do a conditional review (conditional that it not break anything)?
Attachment #120005 - Flags: review?(aaronl)

Comment 3

15 years ago
Comment on attachment 120005 [details] [diff] [review]
patch based on conversation with aaronl

r=aaronl as long as it doesn't break anything :)

Also, once you eliminate ResetBrowseWithCaret() from nsDOMWindowController, it
can be removed from nsIEventStateManager and be turned into a helper:
void ResetBrowseWithCaret(void)
Attachment #120005 - Flags: review?(aaronl) → review+
(Assignee)

Updated

15 years ago
Blocks: 197121
(Assignee)

Updated

15 years ago
Blocks: 201560

Comment 4

15 years ago
Created attachment 120270 [details] [diff] [review]
Tweaked version of the patch, doesn't crash.
Attachment #120005 - Attachment is obsolete: true

Comment 5

15 years ago
Comment on attachment 120270 [details] [diff] [review]
Tweaked version of the patch, doesn't crash.

Moving r= forward, sr=me
Attachment #120270 - Flags: superreview+
Attachment #120270 - Flags: review+

Comment 6

15 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Depends on: 906281
You need to log in before you can comment on or make changes to this bug.