2014060 - [css-attr] attr() should support namespaced attributes.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

A quick run with attr enabled by default shows some interesting failures: https://treeherder.mozilla.org/jobs?repo=try&revision=4242db087491ac39f9e5ad169228b746fc926082

A bunch of them are due to missing namespace support for attr(). The <attr-name> production includes an optional namespace prefix. The content function deals with it, might be worth factoring the namespace_prefix + namespace_url + attribute into a common AttrName struct.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

There are also a few invalidation issues (not totally unexpected).

Comment 3

[Diego Ciudad Real Escalante [:descalante]]

Attachment: Bug 2014060 - Add support for namespaces in attributes used in attr(). r=emilio

Comment 4

[Diego Ciudad Real Escalante [:descalante]]

Attachment: Bug 2014060 - Add wpt testing proper parsing and handling of namespaces in attr function. r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/298da9a3d9c2
https://hg.mozilla.org/integration/autoland/rev/fa90b2078932
Add support for namespaces in attributes used in attr(). r=emilio,firefox-style-system-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/f0e6f7855365
https://hg.mozilla.org/integration/autoland/rev/1b7975726a43
Add wpt testing proper parsing and handling of namespaces in attr function. r=dshin

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58109 for changes under testing/web-platform/tests

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fa90b2078932
https://hg.mozilla.org/mozilla-central/rev/1b7975726a43

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Dave Letorey]

Related issues

• Content PR
• BCD PR
• FF release PR

Comment 10

[Dave Letorey]

I am not sure this is working as expected.

See line 20 in the CSS of this codepen

I could have written this wrong.

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Dave I think it's working fine? The data-color attribute there has null namespace not svg-namespace