201416 - if shistory.dll is missing then home page won't load

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[timeless]

I systematically tested running mozilla w/o dlls.

steps:
1. (about:config) set dom.allow_scripts_to_close_windows to true
2. (edit>prefs) set homepage to javascript:window.close()
3. (edit>prefs) set navigator to load homepage
4. quit.
5. rename shistory.dll to shistory.dul
6. run mozilla

expected results:
mozilla runs without crashing
mozilla opens a navigator window
mozilla loads the homepage
mozilla closes itself (without crashing)

actual results:
navigator opens but does not load the homepage.

jsconsole indicates:
Error: uncaught exception: [Exception... "Component returned failure code:
0x80570015 (NS_ERROR_XPC_CI_RETURNED_FAILURE) [nsIJSCID.createInstance]" 
nsresult: "0x80570015 (NS_ERROR_XPC_CI_RETURNED_FAILURE)"  location: "JS frame
:: chrome://navigator/content/navigator.js :: Startup :: line 522"  data: no]

which should be fixed but wrapping it in a try block.

Comment 1

[timeless]

Attachment: try block - fixes the problem

Comment 2

[Alec Flett]

I'll review this because its probably good error checking, but shistory has been
merged into docshell...

Comment 3

[timeless]

yeah. somehow i managed to run my test scenario on an old build. but it should
be possible to build a navigator without history and i've run into this before.

Comment 4

[Alec Flett]

Comment on attachment 120025 [details] [diff] [review]
try block - fixes the problem

r/sr=alecf
just add a comment indicating why this is in a big try/catch

Comment 5

[timeless]

checked in with comment