if shistory.dll is missing then home page won't load

RESOLVED FIXED

Status

SeaMonkey
UI Design
--
trivial
RESOLVED FIXED
15 years ago
10 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
I systematically tested running mozilla w/o dlls.

steps:
1. (about:config) set dom.allow_scripts_to_close_windows to true
2. (edit>prefs) set homepage to javascript:window.close()
3. (edit>prefs) set navigator to load homepage
4. quit.
5. rename shistory.dll to shistory.dul
6. run mozilla

expected results:
mozilla runs without crashing
mozilla opens a navigator window
mozilla loads the homepage
mozilla closes itself (without crashing)

actual results:
navigator opens but does not load the homepage.

jsconsole indicates:
Error: uncaught exception: [Exception... "Component returned failure code:
0x80570015 (NS_ERROR_XPC_CI_RETURNED_FAILURE) [nsIJSCID.createInstance]" 
nsresult: "0x80570015 (NS_ERROR_XPC_CI_RETURNED_FAILURE)"  location: "JS frame
:: chrome://navigator/content/navigator.js :: Startup :: line 522"  data: no]

which should be fixed but wrapping it in a try block.
(Assignee)

Comment 1

15 years ago
Created attachment 120025 [details] [diff] [review]
try block - fixes the problem
(Assignee)

Updated

15 years ago
Attachment #120025 - Flags: superreview?(alecf)
Attachment #120025 - Flags: review?(alecf)

Comment 2

15 years ago
I'll review this because its probably good error checking, but shistory has been
merged into docshell...
(Assignee)

Comment 3

15 years ago
yeah. somehow i managed to run my test scenario on an old build. but it should
be possible to build a navigator without history and i've run into this before.
Status: NEW → ASSIGNED

Comment 4

15 years ago
Comment on attachment 120025 [details] [diff] [review]
try block - fixes the problem

r/sr=alecf
just add a comment indicating why this is in a big try/catch
Attachment #120025 - Flags: superreview?(alecf)
Attachment #120025 - Flags: superreview+
Attachment #120025 - Flags: review?(alecf)
Attachment #120025 - Flags: review+
(Assignee)

Comment 5

15 years ago
checked in with comment
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Core → Mozilla Application Suite
(Assignee)

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.