201465 - Window "About Junk Mail" has wrong size

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Mirek]

User-Agent:       Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4a) Gecko/20030401
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4a) Gecko/20030401

WinNT Sp6a, Moz build 2003040105
Window "About Junk Mail" has wrong size in case of certain system fonts, the
buttons OK and Help fall out of the window and the window itself is not resizeable.

Reproducible: Always

Steps to Reproduce:
1. This depends on the resulution and fonts selected in the Windows
ControlPanel>Display>appearance.
2. Click on the questionmark button in the header of junk mail.
3.

Actual Results:  
see attachement

Expected Results:  
properly sized window

Comment 1

[Mirek]

Attachment: Sample of the improperly sized window, buttons are almost not visible

Comment 2

[Mike Cowperthwaite]

Confirmed:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030408

I have my system set with "large fonts" (120 dpi).

Comment 3

[K. Richard Pixley]

A scroll bar would also fix the problem.

(WinXP here, large fonts, no buttons, can't even read all the text.)

Comment 4

[Mike Cowperthwaite]

*** Bug 204097 has been marked as a duplicate of this bug. ***

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I am also affected by this (I don't see any buttons, and miss part of the text).
I think this is important to get right, Junk Mail controls are one of our most
noted features.

Comment 6

[Samir Gehani]

adt: nsbeta1+/adt3

Comment 7

[Stefan Borggraefe]

I have a fix for this.

Comment 8

[Stefan Borggraefe]

Attachment: Patch

Get rid of the hard-coded pixel values for the window size and split the text
so the lines don't get to long now.

I also added a small space of 0.5em between "Messages that thinks are junk will
display a junk icon" and the displayed example icon. This looked ugly before.

I'm going to attach some screenshots showing the effect of this patch in a
minute.

Comment 9

[Stefan Borggraefe]

Attachment: Screenshot of the "About Junk Mail" window with a large font on WindowsXP without the patch.

Comment 10

[Stefan Borggraefe]

Attachment: Screenshot of the "About Junk Mail" window with the same font on WindowsXP with the patch.

Comment 11

[Stefan Borggraefe]

Attachment: This is how the dialog looks on Linux with "normal" fonts and the patch applied.

Comment 12

[Stefan Borggraefe]

BTW: Shouldn't the word "Mail" as the program name be replaced with
&brandShortName; in this dialog?

Comment 13

[[e-mail]]

Comment on attachment 131873 [details] [diff] [review]
Patch

Uwrapping the text is wrong. Removing the height is obviously right but I think
the window code assumes a height of 0 if you specify a width; to get around
this I think you need to move the width to the vbox.

Comment 14

[Stefan Borggraefe]

Attachment: Updated patch

With Neil's suggestions the patch is even simpler and the paragraphs are saved.

Comment 15

[Stefan Borggraefe]

Attachment: Final patch.

Removed the spacing change for the little Junk Mail Icon. This should better be
fixed in the themes via another bug.

Comment 16

[Stefan Borggraefe]

Thanks for the reviews and the check-in! :-)

FIXED.

Comment 17

[Stefan Borggraefe]

Comment on attachment 131886 [details] [diff] [review]
Final patch.

Requesting approval for 1.5: This bug makes Mozilla look bad for users who use
Junk Mail detection for the first time. Very low risk.

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 131886 [details] [diff] [review]
Final patch.

a=asa (on behalf of drivers) for checkin to the 1.5 branch. Please add the
fixed1.5 keyword when this fix lands on the branch.