201490 - Mozilla fails to run due to missing StubNNN global data

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jim Brown]

User-Agent:       Mozilla/5.0 (X11; U; OSF1 alpha; en-US; rv:1.2) Gecko/20021205
Build Identifier: mozilla-source-1.4a.tar.gz

/reflect/xptcall/src/md/unix/xptcstubs_asm_osf1_alpha.s does not correctly
generate the STUB_ENTRY declarations because the C preprocessor does not
understand the '##' construct (since -std1 was removed in another bug fix).


Reproducible: Always

Steps to Reproduce:
1. build mozilla
2. try to run, it fails due to undefined Stub data.
3.

Comment 1

[Jim Brown]

Attachment: Patch v1.0, simple fix

Comment 2

[Jim Brown]

Attachment: Patch v1.1, works both ways

Comment 3

[Jim Brown]

This problem was seen on Tru64 V5.1B using system compiler (cc) and Compaq
c++ v6.5 (CC=cc, CXX=cxx, CFLAGS=-pthread).

Comment 4

[David Bradley]

Comment on attachment 120076 [details] [diff] [review]
Patch v1.1, works both ways

r=dbradley

Did you intended inject that last semicolon? The original code doesn't have it.

I'll have to take your word that the /**/ mechanism works.

Comment 5

[Jim Brown]

Attachment: v1.1.1, without extra semi-colon

It got in while I was testing different ways to solve the problem.

Comment 6

[Jim Brown]

Attachment: v1.1.2, restore missing blank lines terminating STUB macros

Compiles cleanly with and without -std1.
Should have done more testing before posting merged patches.

Comment 7

[Jim Brown]

I am satisfied with patch v1.1.2.
It compiles cleanly with/without -std1.
mozilla now runs for me on Tru64 v5.1b.

Comment 8

[David Bradley]

Comment on attachment 120228 [details] [diff] [review]
v1.1.2, restore missing blank lines terminating STUB macros

r=dbradley

Comment 9

[Andrew Schultz]

NEW

Comment 10

[Doug Turner (:dougt)]

Checking in xptcstubs_asm_osf1_alpha.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_asm_osf1_alpha.s,v
 <--  xptcstubs_asm_osf1_alpha.s
new revision: 1.2; previous revision: 1.1
done


Fixed.

Thanks for the fix.

Comment 11

[Wan-Teh Chang]

Comment on attachment 120228 [details] [diff] [review]
v1.1.2, restore missing blank lines terminating STUB macros

Jim,

I don't understand why you said the C preprocessor doesn't handle
## if run with -std.

Here is an experiment that shows the opposite.

diffie:/u/wtc/tmp 47% cat foo.c
#define FOO(n)	before##n##after

int FOO(1);
long FOO(2);
diffie:/u/wtc/tmp 48% cc -V
Compaq C V6.4-214 (dtk) on Compaq Tru64 UNIX V5.0A (Rev. 1094)
Compiler Driver V6.4-014 (dtk) cc Driver
diffie:/u/wtc/tmp 49% cat foo.c
#define FOO(n)	before##n##after

int FOO(1);
long FOO(2);
diffie:/u/wtc/tmp 50% cc -std -E foo.c
# 1 "foo.c"


int  before1after ;
long  before2after ;

Comment 12

[Jim Brown]

I should have been more specific -- the C preprocessor used by the 
assembler has this problem.  Here is an example which clearly shows 
the problem.

% cat f0.s
#define FOO(n)  .globl before##n##after;\
        .ent before##n##after;\
before##n##after:;\
        nop;\
        .end before##n##after

FOO(1);
FOO(2);

% cc -c f0.s
% nm f0.o
"
Name                                    Value        Type       Size

"before                           | 0000000000000000 | N | 0000000000000000
% cc -c -std1 f0.s
% nm f0.o
"
Name                                    Value        Type       Size

"_fpdata                          | 0000000000000000 | U | 0000000000000000
before1after                     | 0000000000000000 | T | 0000000000000008
before2after                     | 0000000000000004 | T | 0000000000000008

Add the extra checks and it can be made to work (generate code) either 
way.

% cat f1.s
#if __STDC__
#define FOO(n)  .globl before##n##after;\
        .ent before##n##after;\
before##n##after:;\
        nop;\
        .end before##n##after
#else
#define FOO(n)  .globl before/**/n/**/after;\
        .ent before/**/n/**/after;\
before/**/n/**/after:;\
        nop;\
        .end before/**/n/**/after
#endif

FOO(1);
FOO(2);

% cc -c f1.s
% nm f1.o
"
Name                                    Value        Type       Size

"_fpdata                          | 0000000000000000 | U | 0000000000000000
before1after                     | 0000000000000000 | T | 0000000000000008
before2after                     | 0000000000000004 | T | 0000000000000008
% cc -c -std1 f1.s
% nm f1.o
"
Name                                    Value        Type       Size

"_fpdata                          | 0000000000000000 | U | 0000000000000000
before1after                     | 0000000000000000 | T | 0000000000000008
before2after                     | 0000000000000004 | T | 0000000000000008