Obsolete help call in Venkman

RESOLVED FIXED

Status

RESOLVED FIXED
16 years ago
2 days ago

People

(Reporter: neil, Assigned: oeschger)

Tracking

Trunk
x86
Windows 95

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
Venkman should be using openHelp() to open help but one of the call sites still
uses toOpenWindowByType.
(Assignee)

Comment 1

16 years ago
Created attachment 120091 [details] [diff] [review]
updating help viewer command

Rob - How does this do ya? openHelp() comes from
chrome://help/content/contextHelp.js, but you are getting it in the XUL from
globalOverlay.xul or some other higher-up available to venkman.xul.

Comment 2

16 years ago
Comment on attachment 120091 [details] [diff] [review]
updating help viewer command

r=rginda, thanks for the patch :)
Attachment #120091 - Flags: review+
(Assignee)

Comment 3

16 years ago
Comment on attachment 120091 [details] [diff] [review]
updating help viewer command

alec--wanna do your help-viewer-regression-fixing-review handiwork on this one
as well? Thanks
Attachment #120091 - Flags: superreview?(alecf)
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED

Comment 4

16 years ago
Comment on attachment 120091 [details] [diff] [review]
updating help viewer command

sr=alecf
Attachment #120091 - Flags: superreview?(alecf) → superreview+

Comment 5

16 years ago
fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Core → Other Applications

Updated

2 days ago
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.