Closed
Bug 201493
Opened 21 years ago
Closed 21 years ago
Obsolete help call in Venkman
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: oeschger)
Details
Attachments
(1 file)
|
657 bytes,
patch
|
rginda
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
Venkman should be using openHelp() to open help but one of the call sites still uses toOpenWindowByType.
|
Assignee | |
Comment 1•21 years ago
|
||
Rob - How does this do ya? openHelp() comes from chrome://help/content/contextHelp.js, but you are getting it in the XUL from globalOverlay.xul or some other higher-up available to venkman.xul.
|
||
Comment 2•21 years ago
|
||
Comment on attachment 120091 [details] [diff] [review] updating help viewer command r=rginda, thanks for the patch :)
Attachment #120091 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 120091 [details] [diff] [review] updating help viewer command alec--wanna do your help-viewer-regression-fixing-review handiwork on this one as well? Thanks
Attachment #120091 -
Flags: superreview?(alecf)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 4•21 years ago
|
||
Comment on attachment 120091 [details] [diff] [review] updating help viewer command sr=alecf
Attachment #120091 -
Flags: superreview?(alecf) → superreview+
|
|
||
Comment 5•21 years ago
|
||
fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Other Applications
|
||
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•