remove nsScrollingView and widget nsScrollbar implementations

RESOLVED FIXED

Status

()

Core
Layout: View Rendering
RESOLVED FIXED
15 years ago
9 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
We can remove nsScrollingView now that support for nsScrollFrame has been
removed.  There is one place I'm not sure about... it's used in:

http://lxr.mozilla.org/seamonkey/source/layout/html/tests/table/TableContentTest/TableContentTest.cpp#486

I suspect that test is not functional, but supposing it was, how would we fix it?

We can also remove the various widget implementations of nsIScrollbar.
I don't know if that test is functional, but it doesn't appear to rely on the
view being a true native-scrollbars scrolling view. Just replace it with
nsScrollPortView.
That test is using things that haven't existed for years (nsIContentDelegate),
and isn't part of the build.
(Assignee)

Comment 3

15 years ago
Created attachment 121161 [details] [diff] [review]
patch

remove nsIScrollbar + implementations and nsScrollingView.  Also removed an
unused file in widget/public.  I've tested that this builds and runs on
windows, mac, and linux.
(Assignee)

Updated

15 years ago
Attachment #121161 - Flags: review?(roc+moz)
Comment on attachment 121161 [details] [diff] [review]
patch

Ahhh, this makes me feel good.

Are you going to collect seperate MOA for each GFX module? I say you don't need
to bother. At least you're only deleting code.
Attachment #121161 - Flags: superreview+
Attachment #121161 - Flags: review?(roc+moz)
Attachment #121161 - Flags: review+
(Assignee)

Comment 5

15 years ago
This was checked in; forgot to close the bug.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Blocks: 492296
You need to log in before you can comment on or make changes to this bug.