201642 - Toolbar google search fails for Hebrew (and probably other non-asci languages)

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Shoshannah Forbes]

When attempting to use the new google bar to search in Hebrew, it seems that the
Hebrew is sent escaped in an way that google thinks it is a diffrent encoding,
thus finding junk.

to repro:
type a hebrew word in google seach
see results

This is what you get when searching from the google toolbar:
http://www.google.com/search?q=%D7%97%D7%99%D7%A4%D7%95%D7%A9%20%D7%91%D7%92%D7%95%D7%92%D7%9C

The same search terms, used directly in google:
http://www.google.co.il/search?q=%E7%E9%F4%E5%F9+%E1%E2%E5%E2%EC&ie=ISO-8859-8-I&hl=iw&btnG=%E7%E9%F4%E5%F9+%E1%E2%E5%E2%EC&lr=

Comment 1

[Shoshannah Forbes]

Forgot to mention: build 2003041005
on osx 10.2.5

Comment 2

[[e-mail]]

The search engine dictionary entries in SearchURLList.plist are missing
"&ie=UTF-8&oe=UTF-8" in the http script. Use PropertyList Editor to add it to
the end of each http line fixes it:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN"
"http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>Google</key>
	<string>http://www.google.com/search?q=%s&amp;ie=UTF-8&amp;oe=UTF-8</string>
	<key>Google Images</key>
	<string>http://images.google.com/images?q=%s&amp;ie=UTF-8&amp;oe=UTF-8</string>
	<key>PreferredSearchEngine</key>
	<string>Google</string>
	<key>Search this Site</key>
	<string>http://www.google.com/search?q=%s
site:%d&amp;ie=UTF-8&amp;oe=UTF-8</string>
</dict>
</plist>

Comment 3

[saari (gone)]

->sfraser seems like an easy fix

Comment 4

[Simon Fraser [no longer active]]

I think this is essentially the same as bug 181243.

Comment 5

[Prachi Gauriar]

Attachment: SearchURLList.plist that makes Google use UTF-8 for search urls.

Patch to change SearchURLList.plist into the version in comment 2.  Sorry about
this... an oversight on my part.

Comment 6

[Prachi Gauriar]

Comment on attachment 120295 [details] [diff] [review]
SearchURLList.plist that makes Google use UTF-8 for search urls.

Is this is an appropriate fix for now?	Perhaps it should be put into
nightlies?

Comment 7

[Simon Fraser [no longer active]]

Comment on attachment 120295 [details] [diff] [review]
SearchURLList.plist that makes Google use UTF-8 for search urls.

Looks good, if it works.

Comment 8

[Jasper]

Mike? This seems to work, and makes lives much easier.

Comment 9

[Mike Pinkerton (not reading bugmail)]

*** Bug 213049 has been marked as a duplicate of this bug. ***

Comment 10

[Jasper]

?

Comment 11

[Mike Pinkerton (not reading bugmail)]

landed