2017252 - Override download target folder with "browser.setDownloadBehavior" before temporary download file is created

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Alexandra Borovova [:Sasha]]

The implementation of browser.setDownloadBehavior on the bug 1989022 introduces a workaround to update the target folder for a download when the download is already started; as a consequence, this requires cleaning up all the partial data downloaded at that time.
Unfortunately, introducing an earlier hook at the JS level wouldn't be sufficient here because at the time the download is created in the JS layer (which is only serializing the platform data to a JS object), there is already a temporary file created.
So it looks like to really avoid the cleanup, we have to interfere much earlier in the platform layer. One idea could be to attach an override download folder to a browsing context object and access it when the decision about the download target folder has to be made (somewhere around here).

One of the limitations of the workaround is:
If you try to download file.txt and the "default" download folder already has a file with the same name, it will be downloaded to the new folder as file(1).txt, and subsequent downloads will then be called file(1)(1).txt, file(1)(2).txt, etc... Because the download logic already modified the filename by using DownloadPaths.createNiceUniqueFile.

Comment 1

[Holger Benl [:hbenl]]

Another limitation of the workaround is that the temporary file won't get cleaned up if the browser dies, so this Playwright test leaves file.txt in the user's Downloads folder (and subsequent tests trying to download file.txt will receive file(1).txt).

Comment 2

[Alexandra Borovova [:Sasha]]

Let's rereview the priority when we do the planning for M20.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 2017252 - Add "DownloadFolderOverride" field to BrowsingContext to override the default download folder per browsing context.

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 2017252 - [webdriver-bidi] Improve identification of global configuration.

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 2017252 - [webdriver-bidi] Use "downloadFolderOverride" property of BrowsingContext to set "destinationFolder" with "browser.setDownloadBehavior".

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5643304a44b4
https://hg.mozilla.org/integration/autoland/rev/b84a84bbee6c
Add "DownloadFolderOverride" field to BrowsingContext to override the default download folder per browsing context. r=dom-core,smaug
https://github.com/mozilla-firefox/firefox/commit/4edba5c3dcf9
https://hg.mozilla.org/integration/autoland/rev/1c0fd54c623c
[webdriver-bidi] Improve identification of global configuration. r=whimboo
https://github.com/mozilla-firefox/firefox/commit/3853d1a7ce7e
https://hg.mozilla.org/integration/autoland/rev/297d38e1c9be
[webdriver-bidi] Use "downloadFolderOverride" property of BrowsingContext to set "destinationFolder" with "browser.setDownloadBehavior". r=jdescottes

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b84a84bbee6c
https://hg.mozilla.org/mozilla-central/rev/1c0fd54c623c
https://hg.mozilla.org/mozilla-central/rev/297d38e1c9be