20181 - [MLK] Leaking nsJISx4501LineBreaker

Status: VERIFIED FIXED

(Core Graveyard :: RDF, defect, P3)

Description

[Patrick C. Beard]

When using an nsCOMPtr<nsILineBreaker>, simply assigning to it causes another
AddRef() to be called on the interface being assigned. However, the line above
returns an object which already has a refCount of 1, so the object leaks. The fix
is as follows:

Index: mozilla/rdf/content/src/nsXULDocument.cpp
===================================================================
RCS file: /cvsroot/mozilla/rdf/content/src/nsXULDocument.cpp,v
retrieving revision 1.204
diff -r1.204 nsXULDocument.cpp
722c722
<          mLineBreaker = lb;
---
>          mLineBreaker = dont_AddRef(lb);

Comment 1

[Frank Tang]

same for word breaker
I copy the code from layout/base/src/nsDocument.cpp . howerver, in there, the pointer is not nsCOMPtr so we should only fix
this place.

Comment 2

[Frank Tang]

fix and check in.

Comment 3

[Tom Everingham]

verified