Closed Bug 2018699 Opened 7 months ago Closed 2 months ago

Migrate simple unit tests to Jest/RTL

Categories

(Firefox :: New Tab Page, enhancement)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
155 Branch
Tracking Flags:
Tracking Status
firefox155 --- fixed

People

(Reporter: maxx, Assigned: thecount)

References

Details

Attachments

(1 file, 2 obsolete files)

Bug 2018699 - Migrate simple unit tests to Jest/RTL. r=#home-newtab-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Migrate the following tests (No Redux interactions required)

  • ErrorBoundary.test.jsx
  • FluentOrText.test.jsx
  • MoreRecommendations.test.jsx
  • ModalOverlay.test.jsx
  • DownloadModalToggle.test.jsx
  • ExternalComponentWrapper.test.jsx
  • ComponentPerfTimer.test.jsx

Migrates 7 unit tests that have no Redux interactions from Enzyme/Karma/Chai
to React Testing Library/Jest:

  • ErrorBoundary.test.jsx
  • FluentOrText.test.jsx
  • MoreRecommendations.test.jsx
  • ModalOverlay.test.jsx
  • DownloadModalToggle.test.jsx
  • ExternalComponentWrapper.test.jsx
  • ComponentPerfTimer.test.jsx

New RTL tests are created under test/unit/jest/content-src/components/.
The original Enzyme files are marked with @enzyme-to-rtl comments pointing
to their RTL equivalents.

Attachment #9547302 - Attachment is obsolete: true
Assignee: nobody → sdowne
Attachment #9618705 - Attachment description: WIP: Bug 2018699 - Migrate simple newtab unit tests from Enzyme/Karma to Jest/RTL. → Bug 2018699 - Migrate simple newtab unit tests from Enzyme/Karma to Jest/RTL.
Status: NEW → ASSIGNED
Attachment #9618898 - Attachment description: WIP: Bug 2018699 - Migrate simple unit tests to Jest/RTL → WIP: Bug 2018699 - Migrate simple unit tests to Jest/RTL. r?thecount
Attachment #9618898 - Attachment description: WIP: Bug 2018699 - Migrate simple unit tests to Jest/RTL. r?thecount → WIP: Bug 2018699 - Migrate simple unit tests to Jest/RTL. r=#home-newtab-reviewers
Attachment #9618898 - Attachment description: WIP: Bug 2018699 - Migrate simple unit tests to Jest/RTL. r=#home-newtab-reviewers → Bug 2018699 - Migrate simple unit tests to Jest/RTL. r=#home-newtab-reviewers

https://hg.mozilla.org/mozilla-central/rev/1339ecf1b192

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox155: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
Attachment #9618705 - Attachment is obsolete: true
Blocks: 2062310
No longer blocks: 2018692
QA Whiteboard: [qa-triage-done-c156/b155]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: