2019332 - Implement RTCIceTransport.getSelectedCandidatePair()/onselectedcandidatepairchange

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, task, P2)

Description

[Byron Campen [:bwc]]

This will probably end up being done along with bug 2019331.

Comment 1

[Byron Campen [:bwc]]

https://wpt.live/webrtc/protocol/candidate-exchange.https.html?interop-2026

Comment 2

[Byron Campen [:bwc]]

There's also a fair number of API surface tests in here: https://wpt.fyi/results/webrtc/idlharness.https.window.html%3Finclude%3D(RTCSessionDescription%7CRTCPeerConnectionIceErrorEvent%7CRTCRtpReceiver%7CRTCDtlsTransport%7CRTCIceTransport%7CRTCDTMFToneChangeEvent%7CRTCError%7CRTCErrorEvent)?label=master&label=experimental&aligned&view=interop&q=label%3Ainterop-2026-webrtc

Comment 3

[Byron Campen [:bwc]]

Attachment: WIP: Bug 2019332: (WIP) Move RTCIceCandidate out of JSImpl.

Refactor to use nICEr's candidate parsing code, lots of new wpt for
RTCIceCandidate's c'tor, a couple of parse fixes, and some
privacy-related spec compliance fixes.

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 2019332: Implement RTCIceTransport selected candidate pair API. r?jib,mjf

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 2019332: Improve assertion descriptions, and update the meta file. r?jib

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 2019332: Some type/const correctness fixes in nICEr. r?mjf

Subsequent changesets rely on these.

Comment 7

[Byron Campen [:bwc]]

Attachment: Bug 2019332: Move RTCIceCandidate out of JSImpl. r?jib,mjf

Refactor to use nICEr's candidate parsing code, lots of new wpt for
RTCIceCandidate's c'tor, a couple of parse fixes, and some
privacy-related spec compliance fixes.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/630597f16e80
https://hg.mozilla.org/integration/autoland/rev/9c6626d29097
Revert "Bug 2019332: apply code formatting via Lando" for causing mochitest failures @ test_interfaces.html

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures @ test_interfaces.html & build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/9c6626d29097b28c8a135bceac26b24e6d9fc186

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html

Failure log build bustage

Comment 10

[Byron Campen [:bwc]]

Ahhhhh, that one. Never seem to remember it.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ac8360095d57
https://hg.mozilla.org/integration/autoland/rev/e3b2a4eeccb4
Some type/const correctness fixes in nICEr. r=mjf
https://github.com/mozilla-firefox/firefox/commit/c2891274cee7
https://hg.mozilla.org/integration/autoland/rev/a6568cbe24c7
Move RTCIceCandidate out of JSImpl. r=jib,mjf,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/b8c5fb79a421
https://hg.mozilla.org/integration/autoland/rev/96ea1675ef39
Implement RTCIceTransport selected candidate pair API. r=jib,mjf,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/26fa2f924a18
https://hg.mozilla.org/integration/autoland/rev/76041e1ce7e1
Improve assertion descriptions, and update the meta file. r=jib
https://github.com/mozilla-firefox/firefox/commit/e0c1effba5f5
https://hg.mozilla.org/integration/autoland/rev/55922077ee67
apply code formatting via Lando

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61334 for changes under testing/web-platform/tests

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/398c8c5b459e
https://hg.mozilla.org/mozilla-central/rev/bd34504e5de0
Some type/const correctness fixes in nICEr. r=mjf
https://github.com/mozilla-firefox/firefox/commit/857e557a078f
https://hg.mozilla.org/mozilla-central/rev/0b91bac01ebb
Move RTCIceCandidate out of JSImpl. r=jib,mjf,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/3b36f37f6be1
https://hg.mozilla.org/mozilla-central/rev/8951c32f6181
Implement RTCIceTransport selected candidate pair API. r=jib,mjf,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/809327edc1c1
https://hg.mozilla.org/mozilla-central/rev/3cd169123fa9
Improve assertion descriptions, and update the meta file. r=jib

Comment 14

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e3b2a4eeccb4
https://hg.mozilla.org/mozilla-central/rev/a6568cbe24c7
https://hg.mozilla.org/mozilla-central/rev/96ea1675ef39
https://hg.mozilla.org/mozilla-central/rev/76041e1ce7e1
https://hg.mozilla.org/mozilla-central/rev/55922077ee67

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 16

[Hamish Willee]

FF154 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/44836 (in review)