2020014 - Select Language combobox is autofocused on about:translations page load

Status: RESOLVED FIXED

(Firefox :: Translations, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

Attachment: about:translations with NVDA output showing the focus jumped from the URL bar to the Select Language combobox

STR:

1. open Firefox Nightly 150
2. type in "about:translations" in the URL bar
3. press Enter and observe the behavior of keyboard focus
4. repeat steps 2-3 with a screen reader running (i.e. NVDA on WinOS) and observe the screen reader's announcement

Expected:

1. focus should be placed, by default, to the web content (web page's container, as it is done for the about:profiles page, for instance). Autofocus is, generally, not expected.

Actual:

1. Select language combobox is autofocused - it forces users to miss Learn more link and Detect language combobox that are placed in the focus order before the autofocused control

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 2020014 - Remove custom about:translations initial focus logic r=ayeddi!

This commit removes the custom initial-focus logic from the about:translations
page, letting the page set its own default focus, starting from the top.

This is much better for assistive technology, since it ensures that screen
readers will pick up the crucial context at the top of the page, including
the top-level learn-more link.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 2020014 - Remove custom about:translations initial focus logic r=ayeddi!

This commit removes the custom initial-focus logic from the about:translations
page, letting the page set its own default focus, starting from the top.

This is much better for assistive technology, since it ensures that screen
readers will pick up the crucial context at the top of the page, including
the top-level learn-more link.

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 2020014 - Remove custom about:translations initial focus logic r=ayeddi!

This commit removes the custom initial-focus logic from the about:translations
page, letting the page set its own default focus, starting from the top.

This is much better for assistive technology, since it ensures that screen
readers will pick up the crucial context at the top of the page, including
the top-level learn-more link.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7d9ef32ef487
https://hg.mozilla.org/integration/autoland/rev/b29fca7ca702
Remove custom about:translations initial focus logic r=ayeddi

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ea15b5c53f7
https://hg.mozilla.org/integration/autoland/rev/718045fa26c6
Revert "Bug 2020014 - Remove custom about:translations initial focus logic r=ayeddi" for causing bc failures @ browser_MLSuggest_integration.js

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_MLSuggest_integration.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/718045fa26c6d81479609edd23eb98c790b4f95e

Push with failures

Failure log -> browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js

Comment 7

[Erik Nordin [:nordzilla]]

This is part of a single backout that spanned multiple bugs.

In the patch stack, I increased the timeout when waiting for a mocked RemoteSettings model to download within our Translations tests, hoping that it might also help to reduce intermittent Translations test failures.

There are a few ml related tests that share our Remote Settings mocks. This test case happens to wait for the full duration of the timeout as part of the success path of the test case.

I've reverted the timeout change, and everything should hopefully be fine now.

I would one day like to either fully separate this code, or unify it in a way that ml doesn't rely on Translations under the hood, so that its more clear where the downstream consumers are.

Comment 8

[Erik Nordin [:nordzilla]]

Restoring the original timeout seems to have fixed the issue:

• https://hg.mozilla.org/try/rev/f90e8c8356a1b6f859b28cf430158700cbf43901
• https://treeherder.mozilla.org/jobs?repo=try&revision=c4b57d3456613bf4d05a01e04ce95a3679a2c8db

---

Attempting re-landing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/46ed14926d99
https://hg.mozilla.org/integration/autoland/rev/8a35e576d8bf
Remove custom about:translations initial focus logic r=ayeddi

Comment 10

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/8a35e576d8bf