202053 - signing of softokn3.dll may fail on OS/2

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Julien Pierre]

The mozilla\security\nss\cmd\cmd\shlibsign\Makefile suffers from several
problems. As is, I cannot execute it under my current build environment with
VACPP and gmake 3.79.2a1 .

Here is the output I get :

[d:\nss\38\mozilla\security\nss\cmd\shlibsign]make
cd mangle; gmake.exe export
gmake.exe[1]: Entering directory `D:/nss/38/mozilla/security/nss/cmd/shlibsign/m
angle'
gmake.exe[1]: Nothing to be done for `export'.
gmake.exe[1]: Leaving directory `D:/nss/38/mozilla/security/nss/cmd/shlibsign/ma
ngle'
nsinstall              -R -m 775 OS22.45_icc_DBG.OBJ/shlibsign.exe ../../../../d
ist/OS22.45_icc_DBG.OBJ/bin
cd mangle; gmake.exe libs
gmake.exe[1]: Entering directory `D:/nss/38/mozilla/security/nss/cmd/shlibsign/m
angle'
nsinstall              -R -m 775 OS22.45_icc_DBG.OBJ/mangle.exe ../../../../../d
ist/OS22.45_icc_DBG.OBJ/bin
gmake.exe[1]: Leaving directory `D:/nss/38/mozilla/security/nss/cmd/shlibsign/ma
ngle'
exec sign.cmd ../../../../dist/OS22.45_icc_DBG.OBJ OS22.45_icc_DBG.OBJ OS2 ../..
/../../dist/OS22.45_icc_DBG.OBJ/lib/softokn3.dll
Unknown command "d:"
MAKE.EXE: [../../../../dist/OS22.45_icc_DBG.OBJ/lib/softokn3.chk] Error 2 (ignor
ed)

[d:\nss\38\mozilla\security\nss\cmd\shlibsign]


There are two problems :
1. The failure should not be ignored . Not having softokn3.chk generated means
that NSS applications such as Mozilla will not be able to enable FIPS mode, a
feature wanted by the government. The fix for this is to remove the "-" from the
rule which causes the error to be ignored .
2. The signing script sign.cmd did not execute . It appears that because I'm
running under the 4OS2 shell, the result is 'Unknown command "d:"' on my system
. This is the first time I run into any build problem related to 4OS2. I have a
fix which works regardless of the shell the user is in, which is to invoke the
default OS/2 command interpreter cmd.exe directly to run the script.

I have attached a suggested patch to resolve these two problems which works fine
on my system. Please review and test it.

Comment 1

[Julien Pierre]

Attachment: Invoke OS/2 command interpreter directly to run batch file

Comment 2

[jhp (no longer active)]

I don't understand.  Where is the "d:" coming from?  There is no drive letter in
the line that calls sign.cmd.

Comment 3

[Julien Pierre]

Javier,

I'm not sure where the "d:" is coming from, except that the problem is that
sign.cmd doesn't work correctly under 4os2 somehow. If I had the exact arguments
passed in to the script I might be able to trace it. But I don't think it's
worth investigating. There are several reasons to force it to run in  CMD.EXE -
this problem, and the use of LIBPATHSTRICT , which only works in CMD.EXE.
Do you have any objection to my patch ?

Comment 4

[jhp (no longer active)]

No objection.  Just curious about the error.  r=pedemont, since kaply's out for
the moment.

Comment 5

[Julien Pierre]

Checked in to NSS_3_8_BRANCH for NSS 3.8.1 :

Checking in Makefile;
/cvsroot/mozilla/security/nss/cmd/shlibsign/Makefile,v  <--  Makefile
new revision: 1.8.2.2; previous revision: 1.8.2.1
done

Also to the NSS tip (3.9) :

Checking in Makefile;
/cvsroot/mozilla/security/nss/cmd/shlibsign/Makefile,v  <--  Makefile
new revision: 1.10; previous revision: 1.9
done

Comment 6

[Matthias Versen [:Matti]]

Comment on attachment 120526 [details] [diff] [review]
Invoke OS/2 command interpreter directly to run batch file

r= Jon Granrose via comment#4