Move atk specific code from xp dir to accessible/src/atk

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: yuanyi21, Assigned: yuanyi21)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

306.00 KB, patch
aaronlev
: review+
Henry.Jia
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
this is a followup to bug 199060.
(Assignee)

Comment 1

16 years ago
Created attachment 120799 [details] [diff] [review]
patch

1. move atk specific idl files into public/atk
2. create some atk specific wrapped accessible classes in src/atk
3. remove #ifdef MOZ_ACCESSIBILITY_ATK/#endif block as more as possible

the patch looks huge just because I moved a lot of code around ;-)
(Assignee)

Comment 2

16 years ago
Comment on attachment 120799 [details] [diff] [review]
patch

Aaron, still have time to take a look?
Attachment #120799 - Flags: review?(aaronl)

Comment 3

16 years ago
Comment on attachment 120799 [details] [diff] [review]
patch

No time to look, can you get r= from within your own team?
(Assignee)

Comment 4

16 years ago
Comment on attachment 120799 [details] [diff] [review]
patch

okay, over to bolian...
Attachment #120799 - Flags: review?(aaronl) → review?(bolian.yin)

Comment 5

16 years ago
Comment on attachment 120799 [details] [diff] [review]
patch

r=aaronl

Hi Kyle. I had time to look at it. I see that this does not yet move any
widget/src/gtk2/mai code over.

Looks good.
Attachment #120799 - Flags: review?(bolian.yin) → review+

Comment 6

16 years ago
Kyle, if you want you can ask Leaf to do a cvs rename of files that are just
moving. That way you can keep the cvs history for those files.

Note to superreviewer, none of this is new code. It's just being moved around.
(Assignee)

Comment 7

16 years ago
Comment on attachment 120799 [details] [diff] [review]
patch

thanks, Aaron. the mai's moving is in another bug 202085.
Attachment #120799 - Flags: superreview?(Henry.Jia)

Comment 8

16 years ago
Comment on attachment 120799 [details] [diff] [review]
patch

Looks good.

sr=Henry
Attachment #120799 - Flags: superreview?(Henry.Jia) → superreview+
(Assignee)

Comment 9

16 years ago
checked in! 

sorry, Aaron, you have to update your local tree, my patch touched over 50 
files.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.