2021055 - trainhopConfig value overrides weather.display value when set by a user

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Maxx Crawford [:maxx]]

STR:

1. Install Nimbus devtools
2. Enroll in the following via newtabConfig:

{
  "type": "multi-payload",
  "payload": [
    {
      "type": "widgets",
      "payload": {
        "enabled": true,
        "weatherForecastEnabled": true 
      }
    },
    {
      "type": "weather",
      "payload": {
        "enabled": true,
        "display": "detailed",
        "reportEndpoint": "https://merino.services.mozilla.com/api/v1/suggest",
        "hourlyEndpoint": "https://merino.services.mozilla.com/api/v1/weather/hourly-forecasts"
      }
    }
  ]
}

3. Open a new tab
4. Expected: The weather widget should be visible/working
5. Click the "..." context menu on the Weather Forecast widget
6. Click the "Switch to simple view" button
7. Expected: The widget switches to "mini" mode and moves from the widget row to the top-right corner
8. Actual: Nothing happens.

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 2021055 - Add logic to respect user-choice prefs for weather.display pref r?#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f856cb35fbcc
https://hg.mozilla.org/integration/autoland/rev/172154e84db6
Add logic to respect user-choice prefs for weather.display pref r=home-newtab-reviewers,thecount

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22d04b52b0eb
https://hg.mozilla.org/mozilla-central/rev/1d592808e38f
Add logic to respect user-choice prefs for weather.display pref r=home-newtab-reviewers,thecount

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1d592808e38f

Comment 5

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/172154e84db6