2021903 - Detailed view: Menu button is missing a label

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Natalie Stroud [:nstroud]]

Prerequisites

To display weather forecast, enable the following prefs:

browser.newtabpage.activity-stream.widgets.system.enabled
browser.newtabpage.activity-stream.widgets.system.weatherForecast.enabled
browser.newtabpage.activity-stream.system.showWeather
browser.newtabpage.activity-stream.weather.display === "detailed"

STR:

1. Turn on NVDA
2. Open Nightly
3. Ensure that the weather widget is in the detailed view
4. Using the TAB key, move focus to the menu button aligned to the right of the city

Actual:

When NVDA reached the menu button in the detailed view of the weather widget, the output is: 'clickable button collapsed subMenu'

Expected:

A label should be added to the menu button with the value of 'More options' or something similar

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 2021903 - Add accessible label to weather forecast detailed view menu button r=#accessibility-frontend-reviewers,#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d491cb84f51d
https://hg.mozilla.org/integration/autoland/rev/a66bce0bdbd1
Add accessible label to weather forecast detailed view menu button r=accessibility-frontend-reviewers,home-newtab-reviewers,reemhamz,ayeddi

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a66bce0bdbd1

Comment 4

[Monica Chiorean]

Using Firefox 150.0a1(20260309092903) before the fix I see 'clickable button collapsed subMenu' in NVDA,
after the fix using Firefox 151.0a1(20260416093720) and 150.0b10 I have 'clickable Open menu button collapsed subMenu'.
Is the new string ok for you [e-mail]? Thank you.