20229 - [MLK] Leaking nsDeque objects

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Patrick C. Beard]

nsCParserNode::~nsCParserNode() can (and does apparently) leak nsDeque objects,
since it only conditionally deletes mAttributes. I'm enclosing a report for
such a leak.

Comment 1

[Patrick C. Beard]

Attachment: annotated stack crawl

Comment 2

[rickg]

The problem is in XIFDTD; nodes will leak children if the nodes themselves are
not handled properly.

Comment 3

[Patrick C. Beard]

But I didn't see nodes leaking, just nsDeques leaking by themselves. Do you
not agree that there's a possibility that the deque isn't deleted because of
the way you've written nsCParserNode::~nsCParserNode()?

Comment 4

[rickg]

No -- the attributes deque is being deleted when the node gets destroyed.

Comment 5

[rickg]

Patrick is the man! Bug was caused by erroneous conditional, which caused
mAttributes deque to leak if it existed but was empty.

Comment 6

[bsharma]

updated qa contact.

Comment 7

[bsharma]

Marking verified as per the developer comments.

Comment 8

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/a02b1ea8022c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20229 - Use the AC common implementation for ads/search telemetry