2023978 - Improve window manipulation for Wayland headless jobs

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For example see the following metadata file:
https://searchfox.org/firefox-main/source/testing/web-platform/meta/webdriver/tests/classic/minimize_window/stress.py.ini#8

At some point the Wayland entries got replaced and are now listed as fallback with [PASS, FAIL], but most of the tests should actually work under headless mode even with Wayland active. We should update the entries accordingly.

Also it would be good to actually have access to the headless flag from within the pytest itself. That way we could exclude some parts of the tests to run (like checks for x and y window coordinates) for headful mode.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: WIP: Bug 2023978 - [wpt] Pass "display" and "headless" values to WebDriver tests.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 2023978 - [wpt] Pass "display" and "headless" values to WebDriver tests.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 2023978 - [wdspec] Update window geometry tests for WebDriver classic and manifests for Wayland headful.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 2023978 - [remote] Allow re-posiioning of chrome windows with Wayland headless.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 2023978 - [marionette] Remove duplicated window manipulation tests from Marionette unit tests.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As a self-reminder I'll check upstream on the wpt repository if we can get rid of checking the display environment variable for Wayland. I need to test this upstream and it makes it hard with this set of patches. So I'll do when the upstream sync is done.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d9d06573ae02
https://hg.mozilla.org/integration/autoland/rev/86956536b752
[marionette] Remove duplicated window manipulation tests from Marionette unit tests. r=jdescottes
https://github.com/mozilla-firefox/firefox/commit/265da6f4c45c
https://hg.mozilla.org/integration/autoland/rev/a8c69b6a691a
[remote] Allow re-posiioning of chrome windows with Wayland headless. r=jdescottes
https://github.com/mozilla-firefox/firefox/commit/8be2ad2875ab
https://hg.mozilla.org/integration/autoland/rev/db75bc81aec7
[wpt] Pass "display" and "headless" values to WebDriver tests. r=Sasha
https://github.com/mozilla-firefox/firefox/commit/a34caac77795
https://hg.mozilla.org/integration/autoland/rev/431bf6148f4a
[wdspec] Update window geometry tests for WebDriver classic and manifests for Wayland headful. r=jdescottes

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/86956536b752
https://hg.mozilla.org/mozilla-central/rev/a8c69b6a691a
https://hg.mozilla.org/mozilla-central/rev/db75bc81aec7
https://hg.mozilla.org/mozilla-central/rev/431bf6148f4a

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8dd9b4db45a6
https://hg.mozilla.org/integration/autoland/rev/2c751e75262a
update test expectations for user_prompts.py because 2 test are unexpecting passing.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fb54841d9ae2
https://hg.mozilla.org/integration/autoland/rev/5e33f3addd95
update test_partial_input expectations because 2 tests are unexpectedly passing.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3e8788c17d10
https://hg.mozilla.org/integration/autoland/rev/a316a7cd5104
update test_partial_input to only pass on linux wayland.

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2c751e75262a
https://hg.mozilla.org/mozilla-central/rev/5e33f3addd95
https://hg.mozilla.org/mozilla-central/rev/a316a7cd5104

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58848 for changes under testing/web-platform/tests

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/683d2eedb117
https://hg.mozilla.org/integration/autoland/rev/71df2ff0b6a0
[wpt PR 58848] - [Gecko Bug 2023978] [wpt] Pass "display" and "headless" values to WebDriver tests., a=testonly

Comment 16

[amarc]

https://hg.mozilla.org/mozilla-central/rev/71df2ff0b6a0

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This bug is fixed but there is a follow-up downstream sync patch to land and the appropriate landing failed but that's unrelated to our implementation.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/58cc4351d02c
https://hg.mozilla.org/integration/autoland/rev/e8953fd7325d
[wpt PR 58848] - [Gecko Bug 2023978] [wpt] Pass "display" and "headless" values to WebDriver tests., a=testonly

Comment 19

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e8953fd7325d