2024523 - [wpt-sync] Sync PR 58597 - Implement typeahead for menu elements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 58597 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58597
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Implement typeahead for menu elements

When inside a menubar or menulist, this patch makes it so that typing
the name of a menuitem will focus it. This matches the behavior for
customizable select.

Fixed: 489358143
Bug: 406566432
Change-Id: Id4601f280aa38088f74da56e85d17c150c2c9823

Reviewed-on: https://chromium-review.googlesource.com/7672280
WPT-Export-Revision: d98f6fd57ac7e873c22b75adbcd7bcf75b422d13

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cc7ead00d9653655e289e4d47b4995774930a47

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 2 subtests

Status Summary

Firefox

OK : 9
PASS : 1
FAIL : 36[Gecko-windows11-32-24h2-opt] 38[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
ERROR: 1

Chrome

OK : 1
FAIL : 2

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/menu/tentative/menu-elements-default-style.html [wpt.fyi]: FAIL
• /html/semantics/menu/tentative/menuitem-anchor-positioning.html [wpt.fyi]: FAIL
• /html/semantics/menu/tentative/button-invoke-menulist.html [wpt.fyi]
  • Button with command=toggle-popover can invoke menulist popover.: FAIL
  • Button with command=toggle-menu can invoke menulist popover.: FAIL
• /html/semantics/menu/tentative/checkable.html [wpt.fyi]
  • menuitem is not checkable on its own: FAIL
  • menuitem in menubar is not checkable: FAIL
  • menuitem in menulist: FAIL
  • checkable menuitem exclusivity: FAIL
  • checkable multiple: FAIL
  • checkable menuitem exclusivity when disconnected: FAIL
  • when fieldset becomes uncheckable, so do its menuitems: FAIL
  • fieldset multiple => single; all but the first checked menuitem gets reset: FAIL
  • Default checkedness and checkedness dirtying are wired up correctly: FAIL
• /html/semantics/menu/tentative/focus-menu-elements-arrowoperations.html [wpt.fyi]
  • Should use arrow keys to move between menuitems in menulist (long delays): FAIL
  • Should use arrow keys to move between menuitems in menulist with display block (long delays): FAIL
  • Should use arrow keys to move between menuitems in menubar (long delays): FAIL
  • Should use arrow keys to move between menuitems in menulist (no delays): FAIL
  • Should use arrow keys to move between menuitems in menulist with display block (no delays): FAIL
  • Should use arrow keys to move between menuitems in menubar (no delays): FAIL
• /html/semantics/menu/tentative/focus-menu-elements-nested-arrowoperations.html [wpt.fyi]
  • Should use arrow keys to move between menuitems in menulist invoked from menubar.: FAIL
  • Should use arrow keys to move between menuitems in menulist invoked from menubar inside a popover without closing the popover.: FAIL
  • Should use arrow keys to move between menuitems: Hide popover on beforetoggle should still work.: FAIL
• /html/semantics/menu/tentative/menu-elements-typeahead.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /html/semantics/menu/tentative/menubar-invoke-menulist.html [wpt.fyi]
  • Menu elements are HTML elements.: FAIL
  • Menuitem with toggle-popover, show-popover, hide-popover commands can invoke menulist popover.: FAIL
  • Menuitem with toggle-menu, show-menu, hide-menu commands can invoke menulist popover.: FAIL
  • hidePopover() on menulist closes the popover.: FAIL
  • menuitems that invoke menulists cannot be checkable: FAIL
• /html/semantics/menu/tentative/menuitem-activate.html [wpt.fyi]
  • User menuitem activation works with the toggle-menu command: FAIL
  • User menuitem activation works with show-popover command: FAIL
  • Menulist inside a popover works correctly; does not get accidentally dismissed by opening submenus: FAIL
  • A mousedown-drag-mouseup gesture on a normal menuitem picks the item: FAIL
  • A mousedown-drag-mouseup gesture on a submenu item leaves both menus open: FAIL
  • :open only applies to the invoker and only works for toggle-menu commands: FAIL
• /html/semantics/menu/tentative/menuitem-interest-invoker.tentative.html [wpt.fyi]
  • InterestEvent dispatches on menuitem hover: FAIL
  • event does not dispatch if invoker menuitem is disabled: FAIL
• /html/semantics/menu/tentative/menulist-popover-attribute.html [wpt.fyi]
  • menulist is a popover by default.: FAIL
• /html/semantics/menu/tentative/uncheck-menuitem-dismiss-popover.html [wpt.fyi]
  • Unchecking an exclusive menuitem should dismiss the menulist: FAIL
  • Swapping exclusive checkedness should dismiss the menulist: FAIL

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4039578757a3
https://hg.mozilla.org/integration/autoland/rev/cacffe9a8b8d
[wpt PR 58597] - Implement typeahead for menu elements, a=testonly
https://github.com/mozilla-firefox/firefox/commit/794264a7c643
https://hg.mozilla.org/integration/autoland/rev/2cc321a38b96
[wpt PR 58597] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cacffe9a8b8d
https://hg.mozilla.org/mozilla-central/rev/2cc321a38b96