Closed Bug 2024733 Opened 2 months ago Closed 1 month ago

[wpt-sync] Sync PR 58620 - Revert "Download and install OpenH264 GMP plugin when installing Firefox"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox151 fixed)

Status:
RESOLVED FIXED
Milestone:
151 Branch
Tracking Flags:
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 58620 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58620
Details from upstream follow.

Jonathan Lee <jonathanjlee@google.com> wrote:

Revert "Download and install OpenH264 GMP plugin when installing Firefox"

#58285 broke CI:

 0:16.19 INFO Downloading OpenH264 plugin
Traceback (most recent call last):
  File "/home/test/web-platform-tests/./wpt", line 10, in <module>
    wpt.main()
  File "/home/test/web-platform-tests/tools/wpt/wpt.py", line 233, in main
    rv = script(*args, **kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 1019, in run
    setup_cls, wptrunner_kwargs = setup_wptrunner(venv, **kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 991, in setup_wptrunner
    setup_cls.setup(kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 252, in setup
    self.setup_kwargs(kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 364, in setup_kwargs
    self.browser.install_openh264(
  File "/home/test/web-platform-tests/tools/wpt/browser.py", line 592, in install_openh264
    openh264_json = FirefoxVcsResources(self.logger).get_openh264_data(binary, channel)
  File "/home/test/web-platform-tests/tools/wpt/browser.py", line 236, in get_openh264_data
    ref = self.get_git_ref(version, channel, rev)
AttributeError: 'FirefoxVcsResources' object has no attribute 'get_git_ref'. Did you mean: 'get_git_refs'?

(I was tempted to fix forward, but it doesn't look trivial because FirefoxAndroidVcsResources.get_git_ref() needs to be reconciled against FirefoxVcsResources.get_git_refs().)

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a4263536d073 https://hg.mozilla.org/integration/autoland/rev/6714dae59b6b [wpt PR 58620] - Revert "Download and install OpenH264 GMP plugin when installing Firefox", a=testonly

https://hg.mozilla.org/mozilla-central/rev/6714dae59b6b

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox151: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.