Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 months ago

Sync web-platform-tests PR 58627 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58627
Details from upstream follow.

Andrew Verge <averge@chromium.org> wrote:

[Connection-Allowlist] Implement "redirects=" param for navigations.

Previously, we blocked all redirects for navigations when a Connection
Allowlist header was enforced. We decided to use a global header param
called redirects= instead. When the value of the param is "allow",
navigations for redirects will be allowed regardless of destination.
When the value is "block", redirects will be blocked regardless of the
destination.

A follow-up CL will implement this same logic for subresource fetch
redirects.

Bug: 492439215
Change-Id: I2f9de6c9a8f9746b2f7f5206e9476709145b77d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7667118
Commit-Queue: Andrew Verge \<averge@chromium.org>
Reviewed-by: Shivani Sharma \<shivanisha@chromium.org>
Reviewed-by: Alex Moshchuk \<alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1602209}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Whiteboard: [wptsync downstream] → [wptsync downstream error]

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Whiteboard: [wptsync downstream error] → [wptsync downstream]

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 months ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=78c197c97f9468a122de6aace8f02244ac00469d

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 months ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e8ed0f18af844de5c5f04fbfeea642f63b3b62f

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 3

•

2 months ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 21 tests and 7 subtests

Status Summary

Firefox

OK : 3[GitHub] 21[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS: 2[GitHub] 49[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 7[GitHub] 71[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

OK : 3
PASS: 2
FAIL: 7

Safari

OK : 3
PASS: 2
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/connection-allowlist/tentative/dedicated-worker-redirect.sub.window.html [wpt.fyi]
- Same-origin dedicated worker main script fetch with redirect fails.: FAIL
/connection-allowlist/tentative/dedicated-worker.sub.window.html [wpt.fyi]
- Cross-origin fetch from a dedicated worker (data: URL) should be blocked by inherited policy.: FAIL
- Dedicated worker with empty connection allowlist cannot perform any fetches.: FAIL
/connection-allowlist/tentative/fetch-redirect.sub.window.html [wpt.fyi]
- Fetch redirect from http://web-platform.test:8000 to http://web-platform.test:8000 fails.: FAIL
- Fetch redirect from http://web-platform.test:8000 to http://not-web-platform.test:8000 fails.: FAIL
/connection-allowlist/tentative/fetch-wildcard.sub.window.html [wpt.fyi]
- Fetch to http://www.web-platform.test:8000 fails.: FAIL
- Fetch to http://www1.web-platform.test:8000 fails.: FAIL
- Fetch to http://www2.web-platform.test:8000 fails.: FAIL
- Fetch to http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000 fails.: FAIL
- Fetch to http://xn--lve-6lad.web-platform.test:8000 fails.: FAIL
- Fetch to http://not-web-platform.test:8000 fails.: FAIL
/connection-allowlist/tentative/fetch.sub.window.html [wpt.fyi]
- Fetch to http://www.web-platform.test:8000 fails.: FAIL
- Fetch to http://www1.web-platform.test:8000 fails.: FAIL
- Fetch to http://www2.web-platform.test:8000 fails.: FAIL
- Fetch to http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000 fails.: FAIL
- Fetch to http://xn--lve-6lad.web-platform.test:8000 fails.: FAIL
- Fetch to http://not-web-platform.test:8000 fails.: FAIL
- Fetch to http://www.not-web-platform.test:8000 fails.: FAIL
- Fetch to http://www1.not-web-platform.test:8000 fails.: FAIL
- Fetch to http://www2.not-web-platform.test:8000 fails.: FAIL
- Fetch to http://xn--n8j6ds53lwwkrqhv28a.not-web-platform.test:8000 fails.: FAIL
- Fetch to http://xn--lve-6lad.not-web-platform.test:8000 fails.: FAIL
/connection-allowlist/tentative/link_header_modulepreload_deny.sub.window.html [wpt.fyi]
- Link header modulepreload to a not allow-listed url fails.: FAIL
/connection-allowlist/tentative/link_header_preload_deny.sub.window.html [wpt.fyi]
- Link header preload to a not allow-listed url fails.: FAIL
/connection-allowlist/tentative/link_rel_modulepreload.sub.window.html [wpt.fyi]
- Modulepreload to http://www.web-platform.test:8000 fails.: FAIL
- Modulepreload to http://www1.web-platform.test:8000 fails.: FAIL
- Modulepreload to http://www2.web-platform.test:8000 fails.: FAIL
- Modulepreload to http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000 fails.: FAIL
- Modulepreload to http://xn--lve-6lad.web-platform.test:8000 fails.: FAIL
- Modulepreload to http://not-web-platform.test:8000 fails.: FAIL
/connection-allowlist/tentative/link_rel_prefetch.sub.window.html [wpt.fyi]
- Prefetch to http://www.web-platform.test:8000 fails.: FAIL
- Prefetch to http://www1.web-platform.test:8000 fails.: FAIL
- Prefetch to http://www2.web-platform.test:8000 fails.: FAIL
- Prefetch to http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000 fails.: FAIL
- Prefetch to http://xn--lve-6lad.web-platform.test:8000 fails.: FAIL
- Prefetch to http://not-web-platform.test:8000 fails.: FAIL
/connection-allowlist/tentative/link_rel_preload.sub.window.html [wpt.fyi]
- Preload to http://www.web-platform.test:8000 fails.: FAIL
- Preload to http://www1.web-platform.test:8000 fails.: FAIL
- Preload to http://www2.web-platform.test:8000 fails.: FAIL
- Preload to http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000 fails.: FAIL
- Preload to http://xn--lve-6lad.web-platform.test:8000 fails.: FAIL
- Preload to http://not-web-platform.test:8000 fails.: FAIL
/connection-allowlist/tentative/navigation-anchor-new-tab.sub.window.html [wpt.fyi]
- Navigation via anchor with target=_blank to http://www.web-platform.test:8000 should fail.: FAIL
- Navigation via anchor with target=_blank to http://not-web-platform.test:8000 should fail.: FAIL
/connection-allowlist/tentative/navigation-redirect-allow.sub.window.html [wpt.fyi]
- Redirect from http://not-web-platform.test:8000 to http://web-platform.test:8000 should fail.: FAIL (Chrome: FAIL, Safari: FAIL)
/connection-allowlist/tentative/navigation-redirect-block.sub.window.html [wpt.fyi]
- Redirect from http://web-platform.test:8000 to http://web-platform.test:8000 should fail.: FAIL (Chrome: FAIL, Safari: FAIL)
- Redirect from http://web-platform.test:8000 to http://not-web-platform.test:8000 should fail.: FAIL (Chrome: FAIL, Safari: FAIL)
- Redirect from http://not-web-platform.test:8000 to http://web-platform.test:8000 should fail.: FAIL (Chrome: FAIL, Safari: FAIL)
/connection-allowlist/tentative/navigation-redirect-default.sub.window.html [wpt.fyi]
- Redirect from http://web-platform.test:8000 to http://web-platform.test:8000 should fail.: FAIL (Chrome: FAIL, Safari: FAIL)
- Redirect from http://web-platform.test:8000 to http://not-web-platform.test:8000 should fail.: FAIL (Chrome: FAIL, Safari: FAIL)
- Redirect from http://not-web-platform.test:8000 to http://web-platform.test:8000 should fail.: FAIL (Chrome: FAIL, Safari: FAIL)
/connection-allowlist/tentative/navigation-response-origin.sub.window.html [wpt.fyi]
- Navigation to http://www.web-platform.test:8000 should fail.: FAIL
- Navigation to http://www1.web-platform.test:8000 should fail.: FAIL
- Navigation to http://www2.web-platform.test:8000 should fail.: FAIL
- Navigation to http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000 should fail.: FAIL
- Navigation to http://xn--lve-6lad.web-platform.test:8000 should fail.: FAIL
- Navigation to http://not-web-platform.test:8000 should fail.: FAIL
- Navigation to http://www.not-web-platform.test:8000 should fail.: FAIL
- Navigation to http://www1.not-web-platform.test:8000 should fail.: FAIL
- Navigation to http://www2.not-web-platform.test:8000 should fail.: FAIL
- Navigation to http://xn--n8j6ds53lwwkrqhv28a.not-web-platform.test:8000 should fail.: FAIL
- Navigation to http://xn--lve-6lad.not-web-platform.test:8000 should fail.: FAIL
/connection-allowlist/tentative/navigation-wildcard.sub.window.html [wpt.fyi]
- Navigation to http://www.web-platform.test:8000 should fail.: FAIL
- Navigation to http://www1.web-platform.test:8000 should fail.: FAIL
- Navigation to http://www2.web-platform.test:8000 should fail.: FAIL
- Navigation to http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8000 should fail.: FAIL
- Navigation to http://xn--lve-6lad.web-platform.test:8000 should fail.: FAIL
- Navigation to http://not-web-platform.test:8000 should fail.: FAIL
/connection-allowlist/tentative/shared-worker.sub.window.html [wpt.fyi]
- Cross-origin fetch from a shared worker (data: URL) should be blocked by inherited policy.: FAIL
- Shared worker with empty connection allowlist cannot perform any fetches.: FAIL
- Shared worker (blob: URL) inherits creator's connection allowlist policy.: FAIL

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Depends on: 2025774

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Depends on: 2025781

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Depends on: 2025795

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Depends on: 2025922

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Depends on: 2026127

Pulsebot

Comment 4

•

1 month ago

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/13ae511befa6 https://hg.mozilla.org/integration/autoland/rev/55feca637127 [wpt PR 58627] - [Connection-Allowlist] Implement "redirects=" param for navigations., a=testonly https://github.com/mozilla-firefox/firefox/commit/530596da0f21 https://hg.mozilla.org/integration/autoland/rev/4983e2b17c0f [wpt PR 58627] - Update wpt metadata, a=testonly

Sandor Molnar[:smolnar]

Comment 5

•

1 month ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/55feca637127
https://hg.mozilla.org/mozilla-central/rev/4983e2b17c0f

Status: NEW → RESOLVED

Closed: 1 month ago

status-firefox151: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 151 Branch

Bugzilla

[wpt-sync] Sync PR 58627 - [Connection-Allowlist] Implement "redirects=" param for navigations.

Categories

(Testing :: web-platform-tests, task, P4)

Tracking

(firefox151 fixed)

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Updated

Comment 1

Comment 2

Comment 3

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Updated

Updated

Updated

Updated

Comment 4

Comment 5