2025091 - [wpt-sync] Sync PR 58631 - Fix renderer crash in showPopover

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 58631 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58631
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Fix renderer crash in showPopover

It's possible for focus/blur handlers to modify the popover
attribute during the auto-focus routine. Avoid that crash.

Fixed: 492780658
Change-Id: If27910c0b64efa132ff18595a9893744d1e70414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7676426
Auto-Submit: Mason Freed \<[e-mail]>
Commit-Queue: Mason Freed \<[e-mail]>
Reviewed-by: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1602381}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8de75bee6e95c67a17b68f7c2c0066e107682d5b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Chrome, and Safari on GitHub CI

Total 102 tests

Status Summary

Firefox

OK : 76[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 77[Gecko-android-em-14-x86_64-debug-geckoview]
PASS : 6[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 3815[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 3832[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 3833[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
CRASH: 1[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 2[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL : 20[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 21[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 26[Gecko-android-em-14-x86_64-debug-geckoview]

Chrome

OK : 1
PASS : 5
CRASH: 1
FAIL : 1

Safari

CRASH: 1
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Crashes

• /html/semantics/popovers/popover-events.html [wpt.fyi]: CRASH [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], OK [Gecko-android-em-14-x86_64-debug-geckoview]
• /html/semantics/popovers/popover-focus-blur-crash.html [wpt.fyi]: CRASH

New Tests That Don't Pass

• /html/semantics/popovers/light-dismiss-event-ordering.tentative.html [wpt.fyi]
  • Tests the order of pointer/mouse events during popover light dismiss.: FAIL
• /html/semantics/popovers/light-dismiss-remove-target.html [wpt.fyi]
  • Light dismiss should still happen if the clicked element is removed during pointerdown.: FAIL
• /html/semantics/popovers/popover-active-document.html [wpt.fyi]
  • showPopover should throw when the document isn't active: FAIL
• /html/semantics/popovers/popover-events.html [wpt.fyi]: CRASH [Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], OK [Gecko-android-em-14-x86_64-debug-geckoview] (Chrome: OK, Safari: ERROR)
  • The "beforetoggle" event (listener) get properly dispatched for popovers: FAIL (Chrome: PASS)
  • The "beforetoggle" event (attribute) get properly dispatched for popovers: FAIL (Chrome: PASS)
  • The "beforetoggle" event is cancelable for the "opening" transition: FAIL (Chrome: PASS)
  • The "beforetoggle" event is not fired for element removal: FAIL (Chrome: PASS)
  • The "toggle" event is coalesced: FAIL (Chrome: PASS)
  • The toggle event is still fired if the popover is removed during focus/blur: FAIL (Chrome: FAIL)
• /html/semantics/popovers/popover-focus-5.html?commandforelement [wpt.fyi]
  • Focusing elements inside a popover with a details element inside, and the after button adjacent to invoker, using commandforelement: FAIL
  • Focusing elements inside a popover with custom-element with a slotted button, followed by a details element, where the after button is adjacent to the invoker, using commandforelement: FAIL
• /html/semantics/popovers/popover-focus-5.html?commandfor [wpt.fyi]
  • Focusing elements inside a popover with a details element inside, and the after button adjacent to invoker, using commandfor: FAIL
  • Focusing elements inside a popover with custom-element with a slotted button, followed by a details element, where the after button is adjacent to the invoker, using commandfor: FAIL
• /html/semantics/popovers/popover-focus-5.html?imperative [wpt.fyi]
  • Focusing elements inside a popover with a details element inside, and the after button adjacent to invoker, using imperative: FAIL
  • Focusing elements inside a popover with custom-element with a slotted button, followed by a details element, where the after button is adjacent to the invoker, using imperative: FAIL
• /html/semantics/popovers/popover-focus-5.html?popovertargetelement [wpt.fyi]
  • Focusing elements inside a popover with a details element inside, and the after button adjacent to invoker, using popovertargetelement: FAIL
  • Focusing elements inside a popover with custom-element with a slotted button, followed by a details element, where the after button is adjacent to the invoker, using popovertargetelement: FAIL
• /html/semantics/popovers/popover-focus-inert-invoker.html [wpt.fyi]
  • Popover focus navigation with an inert invoker: FAIL
• /html/semantics/popovers/popover-focus-inside-shadow-dom.html [wpt.fyi]
  • Focus behavior of popover elements inside shadow DOM: FAIL
• /html/semantics/popovers/popover-focus-inside-slot.html [wpt.fyi]
  • Focus behavior of popover elements inside slot: FAIL
• /html/semantics/popovers/popover-light-dismiss-contextmenu.html [wpt.fyi]
  • Popovers should not be light dismissed during contextmenu event.: FAIL
• /html/semantics/popovers/popover-light-dismiss-touch-scroll.html [wpt.fyi]
  • Popovers should not be light dismissed when scrolling via touch.: FAIL
• /html/semantics/popovers/popover-overlay.html [wpt.fyi]
  • dialog.show() should not put popover dialog in top layer: FAIL
  • dialog.showModal() should put popover dialog in top layer: FAIL
  • dialog.showPopover() should put popover dialog in top layer: FAIL
  • div.showPopover() should put popover div in top layer: FAIL
• /html/semantics/popovers/popover-focus-blur-crash.html [wpt.fyi]: CRASH (Chrome: CRASH, Safari: CRASH)
• /html/semantics/popovers/popover-anchor-nested-display.tentative.html [wpt.fyi]: FAIL [Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c04fa3bde246
https://hg.mozilla.org/integration/autoland/rev/0bbac7c936f3
[wpt PR 58631] - Fix renderer crash in showPopover, a=testonly
https://github.com/mozilla-firefox/firefox/commit/e5418e5d3a05
https://hg.mozilla.org/integration/autoland/rev/e2423a73e35e
[wpt PR 58631] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0bbac7c936f3
https://hg.mozilla.org/mozilla-central/rev/e2423a73e35e

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0bbac7c936f3
https://hg.mozilla.org/mozilla-central/rev/e2423a73e35e