Closed Bug 2025093 Opened 2 months ago Closed 1 month ago

[wpt-sync] Sync PR 58651 - [CompositeClipPathAnimation] Fix clip-path animation with fractional paint offsets

Categories

(Core :: Web Painting, task, P4)

Product:
Core
Component:
Web Painting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
151 Branch
Tracking Flags:
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58651 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58651
Details from upstream follow.

Wangsong Jin <wangsongjin@microsoft.com> wrote:

[CompositeClipPathAnimation] Fix clip-path animation with fractional paint offsets

Use >= instead of == when checking if the mask clip rect matches
InfiniteIntRect. gfx::ToEnclosingRect() can round width/height up by 1
pixel when a fractional paint offset shifts the infinite rect's edges to
non-integer floats, causing the equality check to fail. This resulted in
allocating a ~16M pixel mask layer, triggering compositor tile memory
exhaustion and breaking backdrop-filter.

Bug: 449152897
Change-Id: Icbd6c2266e0e4383ca12a7da344d4da85a01850c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7650181
Commit-Queue: Wangsong Jin \<wangsongjin@microsoft.com>
Reviewed-by: Kevin Ellis \<kevers@chromium.org>
Reviewed-by: Claire Chambers \<clchambers@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1602854}

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 72 tests

Status Summary

Firefox

OK : 1
PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 169[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 238[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/56c840ec6aca https://hg.mozilla.org/integration/autoland/rev/45c29aea9b91 [wpt PR 58651] - [CompositeClipPathAnimation] Fix clip-path animation with fractional paint offsets, a=testonly

https://hg.mozilla.org/mozilla-central/rev/45c29aea9b91

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox151: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.