2025727 - [wpt-sync] Sync PR 58704 - Implement image-animation stopped value

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 58704 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58704
Details from upstream follow.

Seokho Song <[e-mail]> wrote:

Implement image-animation stopped value

The "stopped" value should stop the animation and reset its
timeline [1].

Since kAnimationNone does not call the AnimationState::UpdateMetadata
due to they don't register as animated images, we need to reset the
frame when the transitioning from the 'stopped' value.

Separate updating next_desired_frame_time on paused and sync sequence
difference. And add the reset animation branch for the sync sequence id
different AND sync target is invalid id.

[1] https://drafts.csswg.org/css-image-animation-1/#valdef-image-animation-stopped

Bug: 429459566
Change-Id: I4af7fd47959ead9f00f7e592df3ceed72000a03d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7687054
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Reviewed-by: Florin Malita \<[e-mail]>
Commit-Queue: Seokho Song \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1603921}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=443ca6626bec60f592db4e2aebefd3560f26dfb8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

FAIL: 4

Chrome

FAIL: 4

Safari

FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-image-animation/image-animation-background-stopped.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-image-animation/image-animation-img-paused-normal-mixed.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-image-animation/image-animation-img-stopped.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-image-animation/image-animation-stopped-reset-frame.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b9ea865edb58
https://hg.mozilla.org/integration/autoland/rev/0571938bef11
[wpt PR 58704] - Implement image-animation stopped value, a=testonly
https://github.com/mozilla-firefox/firefox/commit/e1650d8cfb50
https://hg.mozilla.org/integration/autoland/rev/a9cbd07b96c1
[wpt PR 58704] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0571938bef11
https://hg.mozilla.org/mozilla-central/rev/a9cbd07b96c1