Closed Bug 202598 Opened 17 years ago Closed 17 years ago

NSPR won't build under MKS anymore on Win2K

Categories

(NSPR :: NSPR, defect)

x86
Windows 2000
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julien.pierre, Assigned: netscape)

Details

Attachments

(1 file)

Something introduced on 4/18 caused my NSPR build under Win2K to fail the
following way :

C:\nss\38\mozilla\security\nss>gmake build_nspr
nsinstall -D ../../nsprpub/WIN954.0_DBG.OBJ
cd ../../nsprpub/WIN954.0_DBG.OBJ ; \
 sh ../configure \
--enable-win32-target=WIN95 \
--with-dist-prefix='C:/nss/38/mozilla/security/nss/../../dist/WIN954.0_DBG.OBJ'
\
--with-dist-includedir='C:/nss/38/mozilla/security/nss/../../dist/WIN954.0_DBG.O
BJ/include'
creating cache ./config.cache
checking host system type... i586-pc-mks
checking target system type... i586-pc-mks
checking build system type... i586-pc-mks
checking for whoami... echo not_whoami
checking for c++... no
checking for g++... no
checking for gcc... no
checking for CC... no
checking for cxx... no
checking for cc++... no
checking for cl... no
checking whether the C++ compiler (gcc  ) works... no
configure: error: installation or configuration problem: C++ compiler cannot cre
ate executables.
gmake: *** [../../nsprpub/WIN954.0_DBG.OBJ/config.status] Error 1

C:\nss\38\mozilla\security\nss>start

If I do a cvs update -D 04/17/2003 in mozilla/nsprpub, and rebuild, I get (as
before) :

C:\nss\38\mozilla\security\nss>gmake build_nspr
nsinstall -D ../../nsprpub/WIN954.0_DBG.OBJ
cd ../../nsprpub/WIN954.0_DBG.OBJ ; \
 sh ../configure \
--enable-win32-target=WIN95 \
--with-dist-prefix='C:/nss/38/mozilla/security/nss/../../dist/WIN954.0_DBG.OBJ'
\
--with-dist-includedir='C:/nss/38/mozilla/security/nss/../../dist/WIN954.0_DBG.O
BJ/include'
loading cache ./config.cache
checking host system type... i386-pc-mksnt
checking target system type... i386-pc-mksnt
checking build system type... i386-pc-mksnt
updating cache ./config.cache
creating ./config.status
creating Makefile
creating config/Makefile
creating config/autoconf.mk
creating config/nsprincl.mk
creating config/nsprincl.sh
creating config/nspr-config
creating lib/Makefile
creating lib/ds/Makefile
creating lib/libc/Makefile
creating lib/libc/include/Makefile
creating lib/libc/src/Makefile
creating lib/tests/Makefile
creating pkg/Makefile
creating pkg/linux/Makefile
creating pkg/solaris/Makefile
creating pkg/solaris/SUNWpr/Makefile
creating pkg/solaris/SUNWprx/Makefile
creating pr/Makefile
creating pr/include/Makefile
creating pr/include/md/Makefile
creating pr/include/obsolete/Makefile
creating pr/include/private/Makefile
creating pr/src/Makefile
creating pr/src/io/Makefile
creating pr/src/linking/Makefile
creating pr/src/malloc/Makefile
creating pr/src/md/Makefile
creating pr/src/md/windows/Makefile
creating pr/src/memory/Makefile
creating pr/src/misc/Makefile
creating pr/src/threads/Makefile
creating pr/tests/Makefile
creating pr/tests/dll/Makefile
creating pr/src/threads/combined/Makefile
cd ../../nsprpub/WIN954.0_DBG.OBJ ; gmake
gmake[1]: Entering directory `C:/nss/38/mozilla/nsprpub/WIN954.0_DBG.OBJ'

anf it goes on to build NSPR fine.
FYI, my system is a dual Xeon 2.2 GHz, Dell P530 .
It always got recognized as "i386-pc-mksnt" before when building with MKS. Under
cygwin it's 686 for some odd reason.
But it used to build before 4/18/2003, as evidenced by the fact that reverting
the NSPR tree to 4/17/2003 works.
This is caused by the updates to config.guess and config.sub.
Apparently they now recognize MKS, so cls did not keep our
modifications to recognize MKS.

However, there is one key difference.  MKS was identified by
our modifications as "mksnt".  Now the official config.guess
and config.sub identify MKS as "mks".  But we haven't changed
configure.in and configure to use the new name "mks".

Julien, try editing mozilla/nsprpub/configure and change all
instances of "mksnt" to "mks".  This should fix the build
failure.
Yep, that's the problem.  I thought I had those changes in the original patch. 
Obviously not.
Assignee: wtc → seawood
Wan-Teh, Chris,

Thanks. This does solve the problem.
Comment on attachment 121034 [details] [diff] [review]
mksnt* -> mks*

r=wtc.
Attachment #121034 - Flags: review+
The patch has been checked into the mozilla trunk, nspr trunk & ldap trunk. 
Sorry about the trouble.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.3
You need to log in before you can comment on or make changes to this bug.