Need a way to disable showing of bitmap in dialog

VERIFIED FIXED

Status

Core Graveyard
Installer: GRE
--
major
VERIFIED FIXED
15 years ago
9 years ago

People

(Reporter: Sean Su, Assigned: Sean Su)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt2])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

15 years ago
In the GRE installer, the download and install process dialogs have a bitmap
banner image that needs to be hidden via a cmdline arg and config.ini preference.

This is a place holder bug for bugscape bug:
  http://bugscape.mcom.com/show_bug.cgi?id=22333
(Assignee)

Comment 1

15 years ago
setting status and keyword to complement the bugscape bug.
Status: NEW → ASSIGNED
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt2]
(Assignee)

Comment 2

15 years ago
Created attachment 121040 [details] [diff] [review]
patch v1.0

This patch happens to fix a few things:
 * adds cmdline arg and config.ini pref to control showing of the download and
   install progess dialogs
 * going between dialogs rembers the last dialog position so the next dialog
   will be shown in the position of the last dialog.
 * going between dialogs (specially in dialogs that show automatically) no
   longer creates the next dialog to show ontop of all other dialogs.
   This is helpful when user has other dialogs ontop of the installer dialog
   and the installer dialog automatically shows a dialog.  It's non intrusive
   now.
 * setup.exe -h (usage) now works again.
(Assignee)

Updated

15 years ago
Attachment #121040 - Flags: review?(dveditz)
(Assignee)

Updated

15 years ago
Attachment #121040 - Attachment is obsolete: true
Attachment #121040 - Flags: review?(dveditz)
(Assignee)

Comment 3

15 years ago
Created attachment 121251 [details] [diff] [review]
patch v1.1

updated patch contains the following fixes:
 * added more comments to how new functions work
 * cleaned up MoveDlgItem
 * renamed some new functions to be more mnemonic
 * cleaned up a couple of redundant global vars that were left.
 * generalized the way CR is added to .ini strings.
(Assignee)

Updated

15 years ago
Attachment #121251 - Flags: review?(sgehani)
(Assignee)

Comment 4

15 years ago
Created attachment 121314 [details] [diff] [review]
patch v1.2

minor fixes after talking with sgehani.
Attachment #121251 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #121251 - Attachment is obsolete: false
Attachment #121251 - Flags: review?(sgehani)
(Assignee)

Updated

15 years ago
Attachment #121251 - Attachment is obsolete: true

Updated

15 years ago
Attachment #121314 - Flags: review+
(Assignee)

Updated

15 years ago
Attachment #121314 - Flags: superreview?(dveditz)
(Assignee)

Comment 5

15 years ago
Created attachment 121354 [details] [diff] [review]
patch v1.2.1

Forgot to diff the setuprsc dir in the previous patch.	Nothing has else
changed from the review by sgehani.
Attachment #121314 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #121314 - Flags: superreview?(dveditz)
(Assignee)

Updated

15 years ago
Attachment #121354 - Flags: superreview?(dveditz)

Comment 6

15 years ago
Comment on attachment 121354 [details] [diff] [review]
patch v1.2.1

rs=dmose@mozilla.org
Attachment #121354 - Flags: superreview?(dveditz) → superreview+
(Assignee)

Comment 7

15 years ago
this bug fixes several problems (see comment #2).  The look and feel of the
installer would be improved.  The -h fix would help mozilla users figure out how
to control the installers without resorting to looking at and modifying it's
config.ini.  This fix is not risky for 1.4b.
Flags: blocking1.4b?
(Assignee)

Updated

15 years ago
Flags: blocking1.4b?
(Assignee)

Updated

15 years ago
Attachment #121354 - Flags: approval1.4b?

Comment 8

15 years ago
Comment on attachment 121354 [details] [diff] [review]
patch v1.2.1

a=asa (on behalf of drivers) for checkin to 1.4b.
Attachment #121354 - Flags: approval1.4b? → approval1.4b+
(Assignee)

Comment 9

15 years ago
patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

15 years ago
reopening.  patch was backed out due to bug 203194.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

15 years ago
Depends on: 203194
(Assignee)

Comment 11

15 years ago
patch checked in again.
Status: REOPENED → RESOLVED
Last Resolved: 15 years ago15 years ago
Resolution: --- → FIXED

Comment 12

15 years ago
v.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.