In the GRE installer, the download and install process dialogs have a bitmap banner image that needs to be hidden via a cmdline arg and config.ini preference. This is a place holder bug for bugscape bug: http://bugscape.mcom.com/show_bug.cgi?id=22333
setting status and keyword to complement the bugscape bug.
Created attachment 121040 [details] [diff] [review] patch v1.0 This patch happens to fix a few things: * adds cmdline arg and config.ini pref to control showing of the download and install progess dialogs * going between dialogs rembers the last dialog position so the next dialog will be shown in the position of the last dialog. * going between dialogs (specially in dialogs that show automatically) no longer creates the next dialog to show ontop of all other dialogs. This is helpful when user has other dialogs ontop of the installer dialog and the installer dialog automatically shows a dialog. It's non intrusive now. * setup.exe -h (usage) now works again.
Created attachment 121251 [details] [diff] [review] patch v1.1 updated patch contains the following fixes: * added more comments to how new functions work * cleaned up MoveDlgItem * renamed some new functions to be more mnemonic * cleaned up a couple of redundant global vars that were left. * generalized the way CR is added to .ini strings.
Created attachment 121314 [details] [diff] [review] patch v1.2 minor fixes after talking with sgehani.
Created attachment 121354 [details] [diff] [review] patch v1.2.1 Forgot to diff the setuprsc dir in the previous patch. Nothing has else changed from the review by sgehani.
Comment on attachment 121354 [details] [diff] [review] patch v1.2.1 email@example.com
this bug fixes several problems (see comment #2). The look and feel of the installer would be improved. The -h fix would help mozilla users figure out how to control the installers without resorting to looking at and modifying it's config.ini. This fix is not risky for 1.4b.
Comment on attachment 121354 [details] [diff] [review] patch v1.2.1 a=asa (on behalf of drivers) for checkin to 1.4b.
patch checked in.
reopening. patch was backed out due to bug 203194.
patch checked in again.