202619 - crashes on launch if /Library/Internet Plug-Ins/LV7NPlugin is present (from National Instruments LabVIEW 7 beta) [@ nsPluginFile::FreePluginInfo]

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect)

Description

[Nathan Lim]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030411 Chimera/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030411 Chimera/0.7+

Great broswer! Love the tabs!

However, all the versions I've tried (i.e. 0.5, 0.6, 0.7, and one of the nightly
builds from the last week or so) crash on launch (i.e. I never see the browser
window- just the splash screen and then crash to Talkback) when I have the
/Library/Internet Plug-Ins/LV7NPlugin present. This file is installed (I think)
when you install National Instruments' (see www.ni.com) LabVIEW 7 beta. The
software is not yet available to the public, but I can email a copy of the
plug-in to anyone who wants to crash Camino on launch <grin>! :-) 

I have submitted several talkback reports. The most recent two are:

TB232825E
TB238415M

Oh yes! Almost forgot to mention that I also use Mozilla 1.2 which seems to have
no problem whatsoever. If need be, I could upgrade the Mozilla and try that. I
suppose I should upgrade anyway, eh? But where do I find time to download the
latest Mozilla on a 26.4k modem when I have Camino bugs to chase down!  :-) 

Seriously though, great job guys! Keep it up! :-) :-)





Reproducible: Always

Steps to Reproduce:
1. copy LV7NPlugin (available from mailto:[e-mail]) to
/Library/Internet Plug-Ins/LV7NPlugin
2. Launch Camino
3. watch splash screen come up 



Actual Results:  
watch Camino crash and burn... Talkback launches

Expected Results:  
continue to launch and display a browser window

I have submitted several talkback reports. The most recent two are:

TB232825E
TB238415M

Comment 1

[Nathan Lim]

Attachment: National Instruments LabVIEW 7 beta for /Library/Internet Plug-Ins

When this attachment is placed in your /Library/Internet Plug-Ins directory,
Camino will crash on launch. The attachment is installed when Nationa
Instruments' (www.ni.com) LabVIEW 7 beta software is installed on OS X.

You may want to change owner to root after placing the file in the Internet
Plug-ins folder.

Comment 2

[Greg K.]

Nathan, after installing your attachment file into "~/Library/Internet Plug-Ins"
and launching FizzillaMach/2003-04-19-08-trunk, I don't see anything new listed
in <about:plugins>. Do you see anything shown there in Mozilla for this plug-in?
(<about:plugins> seems to be broken in Camino at the moment; see my bug 202714.)
You may want to try MacBinary-encoding that plug-in file and attach it again.

Reassigning to Camino/Plug-Ins for the moment since that's what this bug was
initially reported against.

Comment 3

[Nathan Lim]

Attachment: LV7NPlugin which causes Camino crash on launch when placed in /Library/Internet Plug-ins

Don't know why the last attachment didn't work. This should crash Camino on
launch when placed in the /Library/Internet Plug-ins folder (you'll never see
the browser window).

Comment 4

[Nathan Lim]

Attachment: LV7NPlugin causing Camino crash

Previous attachments didn't work. This one is MacBinary encoded and should
cause a Camino crash when unencoded and placed in the /Library/Internet
Plug-ins folder.

Comment 5

[Nathan Lim]

Comment on attachment 121488 [details]
LV7NPlugin causing Camino crash

I verified that downloading, unencoding and placing this Bugzilla attachment in
/Library/Internet Plug-ins will cause a Camino crash on launch (see Talkback
TB242265X)

Comment 6

[Greg K.]

Confirmed using Camino/2003-04-22-05, crashing at nsPluginFile::FreePluginInfo.

Comment 7

[Greg K.]

Attachment: Crash report generated by Camino/2003-04-22-05 showing crash at nsPluginFile::FreePluginInfo

Comment 8

[Greg K.]

Note that comment 6's crash also generated TB242280W.

Also reproduced using FizzillaMach/2003-04-22-08-trunk, generating TB242281M and
the same stack as attachment 121492 [details]. Reassigning to Browser/Plug-Ins.

Comment 9

[Greg K.]

Possible dup of bug 199212.

Comment 10

[Peter Lubczynski]

*** Bug 199212 has been marked as a duplicate of this bug. ***

Comment 11

[Peter Lubczynski]

Attachment: possible patch?

Looks like none of the code in nsPluginsDirDarwin.cpp, FreePluginInfo was
protected against free'ing null. Here's a patch that just copies the code from
the UNIX implementation that should fix the crash, han't tested it yet though.

Comment 12

[Peter Lubczynski]

Comment on attachment 121560 [details] [diff] [review]
possible patch?

okay, looks good, requesting reviews....

Comment 13

[Simon Fraser [no longer active]]

Comment on attachment 121560 [details] [diff] [review]
possible patch?

This still isn't a good fix. We have to make sure that new/delete, malloc/free
and NSPR alloc/free functions are matched up.

p2cstrdup() calls new[].

fMimeTypeArray, fExtensionArray and fMimeDescriptionArray are also allocated
with new[].

I think this code needs a lot of cleanup. Reassign the bug to me if you want me
to do that.

Comment 14

[Peter Lubczynski]

ok, thanks Simon!

Comment 15

[Simon Fraser [no longer active]]

Sorry, won't be able to get to this.

Comment 16

[Simon Fraser [no longer active]]

*** Bug 196471 has been marked as a duplicate of this bug. ***

Comment 17

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Was this patch tested and known to fix something?  delete and delete[] are
null-safe, so I'm a little puzzled.

Comment 18

[Asa Dotzler [:asa]]

Jay, can you help us determine how widespread is this problem for Mac Mozilla? 

Comment 19

[Asa Dotzler [:asa]]

This is pretty high on the Mac topcrash list. Bryner, can you help us here?
Peterl, do you have cycles to spare for looking into this? 

Comment 20

[Asa Dotzler [:asa]]

With no patch in sight I don't think we're going to block for this. Drivers
would consider a reviewed patch. 

Comment 21

[Jesse Ruderman]

Do any of you still use LabVIEW on Mac?  Would be nice to know if this bug still exists when using up-to-date versions of Firefox and LabVIEW.

Comment 22

[Nate]

I am still using LabVIEW on the Mac. However, I am now using a MacBook Pro (Intel) instead of a G4 based laptop.

I have LabVIEW 8.2, 8.5, 8.6 and a beta version of LabVIEW 2009 installed.

I launched Camino Version 1.6.8 (1.8.1.22 2009061519) and Firefox Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2 without any problem.

Comment 23

[Jesse Ruderman]

Great, thanks Nate!