202632 - Imported NetPositive Bookmarks won't open

Status: RESOLVED INVALID

(SeaMonkey :: Bookmarks & History, defect)

Description

[Dennis]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.4a) Gecko/20030418 Phoenix/0.5+
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.4a) Gecko/20030418 Phoenix/0.5+

I select Bookmarks > Imported NetPostive Bookmarks > BeBits


Reproducible: Always

Steps to Reproduce:
1. select Bookmarks > Imported NetPositive Bookmarks > BeBits
2. Nothing happens

Actual Results:  
Nothing happens

Expected Results:  
The bookmark should have caused Phoenix to open the BeBits website

Comment 1

[Sergei Dolgov]

That's known issue for BeOS port of Phoenix,
probably same trick as it was with Mozilla/XPFE bookmarks (kNC type URL in fallback)

Comment 2

[Pierre Chanial]

I'd like to see it fixed, but I have no BeOS expertize.
over to nobody so that BeOS folks can take it.

Comment 3

[Sergei Dolgov]

pch, it will help me much if you point me to file name and place in it in
Phoenix code, which deals with bookmarks.
I know those things for Mozilla/XPFE, but not yet for Firebird.

Comment 4

[Pierre Chanial]

Dergei: when opening a bookmark:
- from a menu: BookmarksMenu.loadBookmark (in bookmarksMenu.js)
- from a tree: openItemClick (in bookmarksTree.xml)

both then wraps the items in a bookmark selection that is used in 
BookmarksCommand.openBookmark (bookmarks.js)

But the fact that we now use unique URI to identify bookmarks broke database
aggregation (bug 201019).

Comment 5

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 6

[Disreali]

This is not just a problem in Firebird, but the Mozilla browser also. Shouldn't this be changed to "BROWSER"? Bugzilla won't let me change it.

Comment 7

[Mike Connor [:mconnor]]

-> Browser, per previous comment

Comment 8

[Disreali]

I'm not positive, but isn't this the same problem from these previous bugs"

http://bugzilla.mozilla.org/show_bug.cgi?id=65185

http://bugzilla.mozilla.org/show_bug.cgi?id=145858

I'm not a coder so I don't know if these bugs are all caused by the same thing
or not, but it sames that the imported Net+ bookmarks are broken very easily and
often.

Comment 9

[Sergei Dolgov]

Attachment: patch

changing kNC type in old hairy BeOS hack - it puts Net+ bookmarks work again from  SeaMonkey (as component is Mozilla Suite)

For FF line to change is 
http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/src/nsBookmarksService.cpp#3381 
and probably needs different bug to be filed.

review request.

Comment 10

[tqh]

Comment on attachment 205495 [details] [diff] [review]
patch

r=[e-mail]

Comment 11

[Sergei Dolgov]

Comment on attachment 205495 [details] [diff] [review]
patch

change inside #ifdef XP_BEOS - so must be safe for other platforms,
but asking sr anyway

Comment 12

[[e-mail]]

Comment on attachment 205495 [details] [diff] [review]
patch

I'm worried that this will cause other errors such as attempting to perform bookmark-like operations on non-bookmarks.

Comment 13

[Phoenix]

Unfortunately, BeOS support was dropped a long ago making this bug obsolete, so I'm closing it.