20265 - Keyboard shortcuts reversed for Command-O & Command-L

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[Eli Goldberg]

<full bug template omitted due to probability of duplicate and simplicity of
issue>

On all 3 platforms using this morning's builds, Command/Control-O will open a web
location, whereas Command/Control-L will open a file.

This is the opposite of 4.x, and is most likely an accident. Suggest returning to
4.x behavior of Command/Control-O opening a file, and Command/Control-L opening a
web location.

Comment 1

[sairuh (rarely reading bugmail)]

reassigning QA contact.

Comment 2

[sairuh (rarely reading bugmail)]

and changing component: after talking with paulmac and don, shortcuts might
best go under XPMenus...

Comment 3

[saari (gone)]

Reassigning to gramps

Comment 4

[don]

Wow, is this annoying!  Ben, can you fix this for M13?

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

this is an easy fix. BUT -

4.x win Ctrl-O opens the 'open web location' box. Reversing the keys as you
suggest would change this behaviour. I'm far more likely to hit Ctrl-O to open a
web file (to save myself having to use the mouse to click in the location field)
than to open a file, which I rarely do (as my HTML editor sends pages to the
browser automatically)

Furthermore, Ctrl-L doesnt appear to do anything in 4.7.

That said, Ctrl-L doesn't seem a good shortcut key for open file. Any
suggestions? does it actually need one? (is it that common an operation?)

However, in the process of doing this I found the open web location keybinding
got busted, and have fixed that too.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

this behaviour is consistent with 4.7.
marking this as wontfix because I think the behaviour is as it should be :)
(fixed broken Ctrl-O keybinding, checked in.)

okay, so I realise 3.0 behaved differently. if enough people want me to turn
back the clock, I'll reopen and "fix" this ;)

Comment 7

[Eli Goldberg]

Maybe it's consistent with Windows & Linux, but violates the Mac OS HIGs:

4.71 Mac OS:
	Command-O = Open File. Per p.101 of the 1992 Mac HIGs, Command-O should open
a Standard File (now Nav Services) dialog.
	Command-L = Open Location

On the basis that Mac users would have Yet Another reason to eschew Mozilla as a
web browser, I'm re-opening this bug, and changing platform to "Macintosh".
Adding mpt who I think likes being CC'd on these kinds of bugs. ;)

Comment 8

[german]

what? let's go fix this! Ctrl-O is open page Ctrl-L is open Location, no reason
not to do it. This one's easy - all platforms have the same requirements here. I
already filed a duplicate bug similar to Eli's lets see it's Bug 20697. This
affects all platforms (unless there is some convention in Unix that I have never
heard of) and is not only a Mac problem. I have not found 4.7 to show this
behavior, if there ever was an old version I believe that older design had to be
an 'accident'. If we have split dialogs for Location and Files I my vote for L
being Location and O being opening local files.
Now maybe for X and Win32 we could rethink the whole unified open dialog thing,
but that would require an XPFE file browser/picker. On Mac I believe that would
not be such a great idea, since Mac users do not have the notion of a path, when
describing file locations.

Comment 9

[german]

*** Bug 20697 has been marked as a duplicate of this bug. ***

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

BAAAH

okay I'll fix it :P

Comment 11

[don]

Ben, maybe Chris McAfee should get this since he has the keyboard shortcuts
umbrella bug #22529.  Can you two decide who does what here?  Thanks.

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

fix checked in

Comment 13

[sairuh (rarely reading bugmail)]

verified as fixed on all platforms (used comm bits): mac (2000010409), linux
(2000010408), winNT (2000010408).

Comment 14

[Eli Goldberg]

*** Bug 22821 has been marked as a duplicate of this bug. ***

Comment 15

[leger]

BULK MOVE: Changing component from XP Menus to XP Toolkit/Widgets: Menus.  XP 
Menus component will be deleted.