2027100 - Fix too-large gap between navbar and main pane

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Finn Terdal (he/they)]

Attachment: big-gap-1.png

On certain viewport widths, the gap between the moz-page-nav and the main pane is too large. This is likely due to the breakpoint changes in bug 1867385.

Comment 1

[Finn Terdal (he/they)]

Attachment: big-gap-2.png

Comment 2

[Hanna Jones [:hjones]]

Taking a look at this during triage and we think the issue is the styles that are getting applied based on the #categories ID e.g. these styles and these styles. Specifically the margins seem to be messing with the breakpoints.

The cleanest solution would probably just be to change that categories ID on the moz-page-nav to something preferences specific, but this caries the risk of breaking a whole lot of tests/might be painful. The alternative would be to change the selector in common-shared.css to something like #categories:not(moz-page-nav) and remove the #categories styles from preferences.

Comment 3

[Finn Terdal (he/they)]

Attachment: Bug 2027100 - Fix too-large gap between navbar and main pane

Comment 4

[Finn Terdal (he/they)]

Attachment: WIP: Bug 2027100 - Fix too-large gap between navbar and main pane

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6672bd55a51b
https://hg.mozilla.org/integration/autoland/rev/173a0eda1b80
Fix too-large gap between navbar and main pane r=mstriemer,desktop-theme-reviewers

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/173a0eda1b80