jbyte defined incorrectly in jri_md.h

RESOLVED FIXED

Status

Core Graveyard
Java: OJI
--
major
RESOLVED FIXED
15 years ago
7 years ago

People

(Reporter: mkaply, Assigned: Joshua Xia)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
sun-java/stubs/include/jri_md.h

jbyte is defined like this:

typedef char            jbyte;

this is wrong. char can be signed or unsigned depending on the compiler. It
should be set explicitly 

typedef signed char jbyte;

http://lxr.mozilla.org/seamonkey/source/sun-java/stubs/include/jri_md.h#191
(Reporter)

Comment 1

15 years ago
Copying brendan for his opinion.

We've looked at headers on other platforms (ia64, sparc, etc.) and all of them
have this line as signed char, not just char.
Yah, you can't assume char is signed or unsigned.  Be explicit.

I pre-sr=brendan any change that adds the right qualifier.

/be
(Assignee)

Comment 3

15 years ago
yes, it should be:

typedef signed char jbyte;

I am checking all other type and making patch.

Brendan,
Have any suggestion for our "JVM Embedding Interface" module?

Thanks!
Status: NEW → ASSIGNED
(Assignee)

Comment 4

15 years ago
Created attachment 121481 [details] [diff] [review]
change jbyte to be signed char
(Assignee)

Comment 5

15 years ago
Comment on attachment 121481 [details] [diff] [review]
change jbyte to be signed char

branden,

+sr please,
Thanks!
Attachment #121481 - Flags: superreview?(brendan)
Attachment #121481 - Flags: review?(pete.zha)

Comment 6

15 years ago
Comment on attachment 121481 [details] [diff] [review]
change jbyte to be signed char

r=petez
Attachment #121481 - Flags: review?(pete.zha) → review+
(Reporter)

Comment 7

15 years ago
Comment on attachment 121481 [details] [diff] [review]
change jbyte to be signed char

brendan already sred this, and I'm approving it for 1.4b.
Attachment #121481 - Flags: superreview?(brendan)
Attachment #121481 - Flags: superreview+
Attachment #121481 - Flags: approval1.4b+
(Assignee)

Comment 8

15 years ago
checkin->fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Updated

7 years ago
Component: Java: OJI → Java: OJI
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.