20310 - File->Open File->Cancel leads to unhandled exception in navigator.js

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Biswapesh Chatterjee]

Platform: WinNT SP5 on PII with 64MB RAM
Build: 1999112808
Overview: Selecting File->Open File and then 'Calcel'ling leads to unhandled
exception in navigator.js as follows:
********************
JavaScript Error: uncaught exception: [Exception... "Component returned failure
code: 0x8052ffff [nsIFileSpecWithUI.chooseFile]"  nsresult: "0x8052ffff
(<unknown>)"  location: "JS frame :: chrome://navigator/content/navigator.js ::
BrowserOpenFileWindow :: line 922"  data: no]
The corresponding code snippet is as follows:

bin/chrome/navigator/content/default/navigator.js
**************************
  function BrowserOpenFileWindow()
  {
    // Get filespecwithui component.
    var fileSpec = createInstance
( "component://netscape/filespecwithui", "nsIFileSpecWithUI" );
    var url = fileSpec.chooseFile( "Open File" ); // Line 922; exception here
    if ( url != "" ) {
        openNewWindowWith( url );
    }
  }
****************************
Probably cross-platform but tested only on WinNT
Test Case: Start mozilla; From menu, select File->Open File
When the Win FileOpen dialog appears; choose 'Cancel'. Monitor the console
window to see this exception.
A related bug(??) Open File always opens a new window. This option should open
the file in the same window (like NS4.x and IE5) or ask for user choice; either
on screen or through the prefs file. This probably entails changing the
openNewWindowWith(url) (line 924) with something else in navigator.js

Comment 1

[Biswapesh Chatterjee]

This bug is probably related to <a
href="http://bugzilla.mozilla.org/show_bug.cgi?id=14854">bug 14854</a>

Comment 2

[Michael Lowe]

law?

Comment 3

[Bill Law]

Fix checked in this morning, should be in today's build.

Comment 4

[leger]

Adding verifyme keyword.

Comment 5

[Joseph Elwell]

working good on my winNT build 2000022908.
marking verified.

Comment 6

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/70fd77e18683
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20310 - Adds Recently Closed button to tabsTray