Closed Bug 203102 Opened 21 years ago Closed 20 years ago

Investigate/port patches for url field (location/address bar) tab problems

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Platform:
x86
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firebird0.8

People

(Reporter: asa, Assigned: bugs)

References

Details

Attachments

(1 file, 5 obsolete files)

port of "Addresses Neil's Comments"
9.84 KB, patch
Details | Diff | Splinter Review 
There are patches attached at 
http://bugzilla.mozilla.org/show_bug.cgi?id=103720 
and
http://bugzilla.mozilla.org/show_bug.cgi?id=104778

The first one looks good and we should get it into 0.6 if possible. The second
one I'm not sure about.
Target Milestone: --- → Phoenix0.6
The 2nd bug shouldn't exist in the final release of app suite IMHO. It's the 
last chance to get such a dataloss bug out of the way. Also, correct me if I'm 
wrong but I think "Target Milestone" should be set to 1.4final on that bug.
Ok, so I'm an idiot and can't remember that this bug is a Firebird one...

I don't know anything about the progress of the bugs, and I know this project 
is supposed to be bug-driven, but to be realistic, at least 5 Mozilla appsuite 
milestones have come out since Phoenix 0.5. Whether 0.6 gets the bugs fixed 
(please please make them priority) it'll still be very much different and 
better. Leaving 0.6 undone will not get them fixed any sooner. I suggest we try 
to let them in but give it a deadline.
Target Milestone: Phoenix0.6 → Phoenix0.7
*** Bug 207655 has been marked as a duplicate of this bug. ***
Based on comment 3:
Moving (d.o.) 'bug 104778' [which is a Mozilla bug] from bug 207655.
Depends on: 104778
Comment on attachment 125581 [details] [diff] [review]
updated patch based on that for bug 104778 to replicate changes in browser/

not sure now what this was based on
Attachment #125581 - Attachment is obsolete: true
Comment on attachment 125581 [details] [diff] [review]
updated patch based on that for bug 104778 to replicate changes in browser/

only addresses

http://bugzilla.mozilla.org/attachment.cgi?id=114446
*** Bug 206400 has been marked as a duplicate of this bug. ***
This is a patch of the first of two patches that were checked in from bug
104778 .  It seems to work, but I haven't tested it very thouroughly.
This is a patch of the first of two patches that were checked in from bug
104778 .  It seems to work, but I haven't tested it very thouroughly.
This is a patch of the first of two patches that were checked in from bug
104778 .  It seems to work, but I haven't tested it very thouroughly.
This is a patch of the first of two patches that were checked in from bug
104778 .  It seems to work, but I haven't tested it very thouroughly.
http://bugzilla.mozilla.org/show_bug.cgi?id=211879

I think that is a dupe of this
*** Bug 211879 has been marked as a duplicate of this bug. ***
*** Bug 215692 has been marked as a duplicate of this bug. ***
*** Bug 215939 has been marked as a duplicate of this bug. ***
I accidentally submitted a duplicate of this bug because I didn't find it when searching.  (Since it is a UI issue, I searched for Firebird bugs, not Mozilla bugs.)  For future searches, summary of the bug I reported:

If you enter part of a URL in the location bar, then switch to a different tab,
then switch back to the original tab, the text you typed in the location bar is
gone.
*** Bug 216803 has been marked as a duplicate of this bug. ***
*** Bug 216871 has been marked as a duplicate of this bug. ***
*** Bug 217051 has been marked as a duplicate of this bug. ***
*** Bug 217272 has been marked as a duplicate of this bug. ***
Target Milestone: Firebird0.7 → Firebird0.8
*** Bug 218046 has been marked as a duplicate of this bug. ***
*** Bug 218422 has been marked as a duplicate of this bug. ***
*** Bug 218494 has been marked as a duplicate of this bug. ***
Comment on attachment 128348 [details] [diff] [review]
port of "Addresses Neil's Comments"

Can you explain the "This could cause problems" comments?  This isn't in the
code it was ported from... what problems are you referring to?
Well, I really had no idea how the code worked, so I just tried to merge it to
the best of my abilities.  The places where I couldn't figure out what was going
on because of differences in function parameters, so I just put a note.  But the
patch is incredibly messed up anyway.  When applied, Firebird refuses to close
tabs most of the time, but I have no idea what it is going on, although I would
guess that it was one of the lines that I noted that causes it.
*** Bug 218822 has been marked as a duplicate of this bug. ***
*** Bug 219517 has been marked as a duplicate of this bug. ***
-> me
Assignee: hyatt → bugs
Priority: -- → P1
QA Contact: asa
Looking at this tonight.
Status: NEW → ASSIGNED
Target Milestone: Firebird0.8 → Firebird0.7
Patch applies but does not work against the trunk. -> 0.8
Target Milestone: Firebird0.7 → Firebird0.8
Comment on attachment 128344 [details] [diff] [review]
port of "Addresses Neil's Comments"

one patch is enough ;-)
Attachment #128344 - Attachment is obsolete: true
Attachment #128346 - Attachment is obsolete: true
Attachment #128347 - Attachment is obsolete: true
*** Bug 220563 has been marked as a duplicate of this bug. ***
*** Bug 221688 has been marked as a duplicate of this bug. ***
*** Bug 221834 has been marked as a duplicate of this bug. ***
*** Bug 221884 has been marked as a duplicate of this bug. ***
*** Bug 221903 has been marked as a duplicate of this bug. ***
*** Bug 222334 has been marked as a duplicate of this bug. ***
*** Bug 222381 has been marked as a duplicate of this bug. ***
*** Bug 225693 has been marked as a duplicate of this bug. ***
*** Bug 226430 has been marked as a duplicate of this bug. ***
*** Bug 226515 has been marked as a duplicate of this bug. ***
People will be searching for "address bar" and "location bar". Adding them
to summary to prevent another dozen dupes.
Summary: investigate/port patches for url field tab problems → Investigate/port patches for url field (location/address bar) tab problems
*** Bug 226670 has been marked as a duplicate of this bug. ***
Flags: blocking0.8?
Will Levine's patch checked in with a couple of modifications. 
And, after waiting all that time for the bug to be processed, I forgot to mark
it fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031206
Firebird/0.7+

Typing a partial URL then switching tabs remembers what was typed fine, but
Firebird's manifestation of bug 103720 doesn't seem to have been fixed (opening
a link in new tab should prefill the location with the link location). 
Actually, I'm not sure if that bug was ever included in this bug's dependencies
even though it was mentioned in the original report.

Also, the URL is still lost upon tab switching if I switch tabs after hitting
Enter but before the page loads.
Ben apparently doesn't read bug mail so needs to be notified, or Asa needs to
reopen the bug.
Comments claim that this bug has not been fixed all the way (fixing
bug 104778 in part and not addressing bug 103720 at all).  Reopening.
Status: RESOLVED → REOPENED
Depends on: 103720
Resolution: FIXED → ---
Please file new bugs on the remaining issues.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
Was there any bugs filed for the remaining issues?
Some (probably many) of us are watching this bug for updates on disappearing url
/ location / address bar text.  If these issues are to be tracked in new bug
reports, please note the new bug numbers here, so we don't have to waste our
time searching for them.  Thank you.
*** Bug 228317 has been marked as a duplicate of this bug. ***
*** Bug 229361 has been marked as a duplicate of this bug. ***
*** Bug 230819 has been marked as a duplicate of this bug. ***
So, I dont get this, this is marked as fixed, still, opening a new window doesnt
add the url until its loaded. Wasnt that what bug 103720 was about? 

Using 0.8 branch build 20040114, Windows XP.
Opened Bug 231393 to fully address the fixes which Bug 103720 addressed as I did
not find a bug that covered it.
I guess everybody should update their votes (move them to bug 231393) then?
*** Bug 207458 has been marked as a duplicate of this bug. ***
Pre-release cleanup
Flags: blocking0.8? → blocking0.8+
(In reply to comment #57)
> So, I dont get this, this is marked as fixed, still, opening a new window doesnt
> add the url until its loaded. Wasnt that what bug 103720 was about? 
> 
> Using 0.8 branch build 20040114, Windows XP.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040611 Firefox/0.8.0+
(daihard: XFT+GTK2; opt. for P4/SSE-2)

Agreed. URLs are still absent until the page starts loading.

Did something fall on the floor?
Ah, yes, URLs are still absent until the page starts loading.  The bug reported
is thus not fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
D'oh, we've moved to bug 231393.  I should have re-read back further first.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 20 years ago
Resolution: --- → FIXED
*** Bug 277111 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: