Remove unused class nsXMLExtras

RESOLVED FIXED in mozilla1.4beta

Status

()

Core
XML
--
trivial
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Heikki Toivonen (remove -bugzilla when emailing directly), Assigned: Heikki Toivonen (remove -bugzilla when emailing directly))

Tracking

({memory-footprint})

Trunk
mozilla1.4beta
memory-footprint
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Class nsXMLExtras is not used in nsXMLExtrasModule.cpp and can be removed.
Actually, it is used to register the XMLExtras components, but we could probably
still get rid of the class and register the components in some other way.
Created attachment 121462 [details] [diff] [review]
Proposed fix

Noticed nameset class was also unused, so removed that as well.
Attachment #121462 - Flags: superreview?(jst)
Attachment #121462 - Flags: review?(harishd)
Comment on attachment 121462 [details] [diff] [review]
Proposed fix

Nice! sr=jst
Attachment #121462 - Flags: superreview?(jst) → superreview+

Comment 4

15 years ago
Comment on attachment 121462 [details] [diff] [review]
Proposed fix

r=harishd
Attachment #121462 - Flags: review?(harishd) → review+
Trivial, safe, small footprint win. Can I land for 1.4b?
Status: NEW → ASSIGNED
Flags: blocking1.4b?
Whiteboard: [fixinhand]
Target Milestone: --- → mozilla1.4beta

Comment 6

15 years ago
Comment on attachment 121462 [details] [diff] [review]
Proposed fix

a=asa (on behalf of drivers) for checkin to 1.4b. 

Heikki, use the patch flag "approval1.4b?" to request approval to land a
reviewed fix. Use the bug flag "blocking1.4b?" to let drivers know you think
the release shouldn't happen without this bug being fixed.
Attachment #121462 - Flags: approval1.4b+
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Flags: blocking1.4b?
Resolution: --- → FIXED
Whiteboard: [fixinhand]
You need to log in before you can comment on or make changes to this bug.