Closed
Bug 203111
Opened 21 years ago
Closed 21 years ago
Remove unused class nsXMLExtras
Categories
(Core :: XML, defect)
Core
XML
Tracking
()
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: hjtoi-bugzilla, Assigned: hjtoi-bugzilla)
Details
(Keywords: memory-footprint)
Attachments
(1 file)
2.47 KB,
patch
|
harishd
:
review+
jst
:
superreview+
asa
:
approval1.4b+
|
Details | Diff | Splinter Review |
Class nsXMLExtras is not used in nsXMLExtrasModule.cpp and can be removed.
Assignee | ||
Comment 1•21 years ago
|
||
Actually, it is used to register the XMLExtras components, but we could probably still get rid of the class and register the components in some other way.
Assignee | ||
Comment 2•21 years ago
|
||
Noticed nameset class was also unused, so removed that as well.
Assignee | ||
Updated•21 years ago
|
Attachment #121462 -
Flags: superreview?(jst)
Attachment #121462 -
Flags: review?(harishd)
Comment 3•21 years ago
|
||
Comment on attachment 121462 [details] [diff] [review] Proposed fix Nice! sr=jst
Attachment #121462 -
Flags: superreview?(jst) → superreview+
Comment on attachment 121462 [details] [diff] [review] Proposed fix r=harishd
Attachment #121462 -
Flags: review?(harishd) → review+
Assignee | ||
Comment 5•21 years ago
|
||
Trivial, safe, small footprint win. Can I land for 1.4b?
Status: NEW → ASSIGNED
Flags: blocking1.4b?
Whiteboard: [fixinhand]
Target Milestone: --- → mozilla1.4beta
Comment 6•21 years ago
|
||
Comment on attachment 121462 [details] [diff] [review] Proposed fix a=asa (on behalf of drivers) for checkin to 1.4b. Heikki, use the patch flag "approval1.4b?" to request approval to land a reviewed fix. Use the bug flag "blocking1.4b?" to let drivers know you think the release shouldn't happen without this bug being fixed.
Attachment #121462 -
Flags: approval1.4b+
Assignee | ||
Comment 7•21 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Flags: blocking1.4b?
Resolution: --- → FIXED
Whiteboard: [fixinhand]
You need to log in
before you can comment on or make changes to this bug.
Description
•