Enable nova designs for new tab
Categories
(Firefox :: New Tab Page, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox151 | --- | fixed |
People
(Reporter: maxx, Assigned: maxx)
References
(Blocks 1 open bug, Regressed 2 open bugs)
Details
(Keywords: perf-alert)
Attachments
(1 file, 1 obsolete file)
Flip the pref browser.newtabpage.activity-stream.nova.enabled to true by default
|
Assignee | |
Comment 1•1 month ago
|
||
|
|
Assignee | |
Comment 2•1 month ago
|
||
The about:home startup cache is constructed via ReactDOMServer.renderToString inside a Web Worker where document is not defined. With nova.enabled now true by default, three render-path functions access document.dir unconditionally, causing startup cache construction to fail with "document is not defined".
Guard each access with typeof document !== "undefined" in WallpaperCategories, SectionsMgmtPanel, and WidgetsManagementPanel.
|
||
Comment 3•1 month ago
|
||
Comment on attachment 9570650 [details]
WIP: Bug 2032213 - Guard document.dir access in Nova render paths for startup cache worker r?#home-newtab-reviewers
Revision D294670 was moved to bug 2032462. Setting attachment 9570650 [details] to obsolete.
|
|
||
Updated•1 month ago
|
Backed out for causing multiple failures at test_backup.py
Backout link
Push with failures
Failure log(s)
|
|
Assignee | |
Updated•1 month ago
|
|
||
Comment 9•1 month ago
|
||
(In reply to amarc from comment #8)
Perfherder has detected a talos performance change from push 42316e0385319d466385b847d04d911242a1e8cb.
No action is required from the author; this comment is provided for informational purposes only.
| Improvement | Test | Platform | Options | Absolute values [old vs new] |
|---|---|---|---|---|
| 37% | tp5n main_normal_fileio (doc) | windows11-64-24h2-shippable | e10s fission stylo webrender | 39,230,709.17 -> 24,755,749.42 |
Need Help or Information?
If you have any questions, please reach out to fbilt@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
|
||
Updated•1 month ago
|
|
||
Comment 10•1 month ago
|
||
(In reply to Pulsebot from comment #4)
Pushed by mcrawford@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/fa6bbbb078a4
https://hg.mozilla.org/integration/autoland/rev/2ca526d3d11b
Enable nova layout by default for new tab r=home-newtab-reviewers,mconley
Perfherder has detected a talos performance change from push 2ca526d3d11ba0fb8ce78ef007be67dcda2c1db0.
No action is required from the author; this comment is provided for informational purposes only.
| Improvement | Test | Platform | Options | Absolute values [old vs new] |
|---|---|---|---|---|
| 33% | tp5n main_normal_fileio (doc) | windows11-64-24h2-shippable | e10s fission stylo webrender | 38,960,131.00 -> 25,929,996.92 |
Need Help or Information?
If you have any questions, please reach out to bacasandrei@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
|
||
Comment 11•6 days ago
|
||
The new NTP is great but it regressed this bug (scrollbar is present even when not needed) https://bugzilla.mozilla.org/show_bug.cgi?id=1407770 https://bugzilla.mozilla.org/show_bug.cgi?id=1466888
Description
•