2032462 - Guard document.dir access in Nova render paths for startup cache worker compatibility

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Maxx Crawford [:maxx]]

When nova.enabled is true by default, three component render functions access document.dir unconditionally. The about:home startup cache is built via ReactDOMServer.renderToString inside a Web Worker where document is not defined, causing construction to fail silently and breaking the startup cache.

Guard each access with typeof document !== "undefined" in:

• WallpaperCategories.jsx
• SectionsMgmtPanel.jsx
• WidgetsManagementPanel.jsx

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 2032462 - Guard document.dir access in Nova render paths for startup cache worker r?#home-newtab-reviewers

The about:home startup cache is constructed via ReactDOMServer.renderToString inside a Web Worker where document is not defined. With nova.enabled now true by default, three render-path functions access document.dir unconditionally, causing startup cache construction to fail with "document is not defined".

Guard each access with typeof document !== "undefined" in WallpaperCategories, SectionsMgmtPanel, and WidgetsManagementPanel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/349ae7ce0948
https://hg.mozilla.org/integration/autoland/rev/76ef2bcb5a01
Guard document.dir access in Nova render paths for startup cache worker r=home-newtab-reviewers,mconley

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/76ef2bcb5a01