203251 - Cancelling Add Account Wizard gives error message in JS console

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Ian Neal]

Using BuildID 2003041808 on WinXP SP1
Steps to reproduce
1. Go into MailNews
2. Select Edit, Mail & Newsgroups Account Settings
3. Click on Add Account button
4. Click on cancel

Actual Results
1. Following error message appears in JS console:
Error: gNewAccountToLoad is not defined
Source File: chrome://messenger/content/accountUtils.js
Line: 241

Expected Result
1. No error message

Fix:
Put a something along the lines of gNewAccountToLoad = null; as the first line
of the function msgOpenAccountWizard() in accountUtils.js

Comment 1

[Ian Neal]

I think this error occurs because gNewAccountToLoad is only set in
msgMail3PaneWindow.js and the function msgOpenAccountWizard() is called from
more than just the 3 Pane Window. So the declaration probably has to be done in
accountUtils.js as well. 

Comment 2

[Ian Neal]

Attachment: Simple patch v1.0

Sets gNewAccountToLoad to null at beginning of msgOpenAccountWizard function

Comment 3

[Ian Neal]

Reassigning

Comment 4

[Ian Neal]

Accepting, can someone review?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 121599 [details] [diff] [review]
Simple patch v1.0

sr=me, but have Seth take a look at this, please...

(also, does that need to be var gNewAccountToLoad? or is it already declared?)

Comment 6

[Ian Neal]

It's declared in msgMail3PaneWindow.js, line 64 :

var gNewAccountToLoad = null;

Comment 7

[(not reading, please use [e-mail] instead)]

fixed.  thanks ian.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; no JS errors in the console using trunk 2006-01-12-10 of SeaMonkey under Windows XP.