203292 - Remove MingW resource hacks

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Jonathan Wilson]

at the moment, MingW builds are using some hacks to get around problems with the
MingW resource compiler, windres. Once the new windres comes out (with the fixes
for the problems), we can remove the hacks.

Comment 1

[Dimitrie O. Paun]

GNU binutils 2.14 has been released. It contains all the necessary changes to windres to 
allow us to remove the hacks. Let's up the required version of binutils to 2.14 and I will 
try to send it a patch to clear up the ugliness. 

Comment 2

[Jonathan Wilson]

But can you get a MingW binutils 2.14 yet?

Comment 3

[Dimitrie O. Paun]

Not yet, apparently. Is there anything we can do to make this happen? 

Comment 4

[Simon Paquet [:sipaq]]

binutils 2.14.90 have been released for MingW

Comment 5

[cls]

Attachment: v1.0

Add windres version check and remove old mingw resource hacks.

Comment 6

[cls]

Comment on attachment 131479 [details] [diff] [review]
v1.0

> bryner: any thoughts on bumping the mingw build requirements?
<bryner> cls: is this because of w32api changes?
> bryner: yes and the windres fix
<bryner> i'm fine with it

Comment 7

[cls]

Patch has been checked in.

Comment 8

[[e-mail]]

They've been "released" but they're not "current" yet :-/